-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to v0.21.0 #34
Bump to v0.21.0 #34
Conversation
Signed-off-by: meichuntao <mei.chuntao@zte.com.cn>
…eus#2139) Signed-off-by: Simon Pasquier <spasquie@redhat.com>
* Revert "slack: retry 429 errors (prometheus#2112)" (prometheus#2128) This reverts commit 26cc96a. Signed-off-by: Simon Pasquier <spasquie@redhat.com> * Revert "config: remove support for JSON marshaling (prometheus#2086)" (prometheus#2133) This reverts commit 918f08b. Signed-off-by: Simon Pasquier <spasquie@redhat.com> * config: fix JSON unmarshaling for HostPort (prometheus#2134) Signed-off-by: Simon Pasquier <spasquie@redhat.com> * Cut 0.20.0 (prometheus#2137) Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: johncming <johncming@yahoo.com>
Signed-off-by: Max Inden <IndenML@gmail.com>
MAINTAINERS.md: Remove Max Inden (mxinden)
…eus#2154) Signed-off-by: Sho Okada <shokada3@gmail.com>
…#2161) Signed-off-by: Kevin Hellemun <17928966+OGKevin@users.noreply.github.com>
* spelling: inhibition Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: matchers Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: notification Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: nonexistent Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: obfuscated Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: occurred Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: relevant Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unexpected Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: marshaled Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: marshaling Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
Signed-off-by: Melchior MOULIN <m.moulin@criteo.com>
…e validation. EOM (prometheus#2173) * Fix an error message about start and end time validation Signed-off-by: Célian Garcia <celian.garcia@amadeus.com> * Modified start and end time validation message to be affirmative Signed-off-by: Célian Garcia <celian.garcia@amadeus.com>
I've been largely inactive for the last 6 months, and have no plans to become active again. Signed-off-by: stuart nelson <stuartnelson3@gmail.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
During the dev Summit 2019/2, there was a consensus to mark stale PR after 60 days. This change is adding the stale bot configuration required for this. The stale bot has already has access to the Prometheus organization. It does _not_ comment and does _not_ close the stale pull request. It just adds a label 'stale'. This is already done in the collectd_exporter repository and there it works as expected. https://docs.google.com/document/d/1VVxx9DzpJPDgOZpZ5TtSHBRPuG5Fr3Vr6EFh8XuUpgs/edit Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
Signed-off-by: m-masataka <m.mizukoshi.wakuwaku@gmail.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Fixed dispatcher metrics registration
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
add shebang for test script Signed-off-by: alan <zg.zhu@daocloud.io>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
* fix dispatcher race condition Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * add test to check for race condition in dispatcher Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * return when dispatcher Stop has nil receiver Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com> * remove unneeded chec Signed-off-by: Jacob Lisi <jacob.t.lisi@gmail.com>
Signed-off-by: Dominik <dominik-k@mailbox.org>
Signed-off-by: Carlos de Paula <me@carlosedp.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
.github/ISSUE_TEMPLATE.md: fix typo
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
* Improve remark on UDP/TCP for high availability Signed-off-by: Pascal Hofmann <mail+github@pascalhofmann.de> * Update README.md Co-Authored-By: Max Inden <mail@max-inden.de> Signed-off-by: Pascal Hofmann <mail+github@pascalhofmann.de> * Update README.md Signed-off-by: Pascal Hofmann <mail+github@pascalhofmann.de> Co-authored-by: Max Inden <mail@max-inden.de>
Move the `alertmanager.url` to a new line. Signed-off-by: Razique Mahroua <rmahroua@redhat.com>
* Enforce 512kb event size limit for Pagerduty Signed-off-by: Shamil Ishraq <shamil@pagerduty.com> * Add size limit to error message Signed-off-by: Shamil Ishraq <shamil@pagerduty.com> * Replace MaxEventSize setting with a const. Signed-off-by: Shamil Ishraq <shamil@pagerduty.com> * Change to package variable Signed-off-by: Shamil Ishraq <shamil@pagerduty.com> * Removed recursion in encodeMessage() Signed-off-by: Shamil Ishraq <shamil@pagerduty.com> * Unexport maxEventSize Signed-off-by: Shamil Ishraq <shamil@pagerduty.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Fahri Yardımcı <f.yardimci06@gmail.com> Signed-off-by: Fahri Yardımcı <f.yardimci06@gmail.com>
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Bump Prometheus orb to 0.6.0
Signed-off-by: LucasBoisserie <lucas.boisserie@gmail.com>
* api/v2: add path and method to API v2 logs When an API v2 handler logged a message, the log wouldn't include the path and method. Since different handlers perform the same validations (e.g. matchers for alerts and silences), it isn't easy to know which handler was invoked (though the logged filename + line number provides a hint). Signed-off-by: Simon Pasquier <spasquie@redhat.com> * Capitalize messages + improve logs Signed-off-by: Simon Pasquier <spasquie@redhat.com>
* .circleci/config.yml: collect test metadata Signed-off-by: Simon Pasquier <spasquie@redhat.com> * Store frontend test results too Signed-off-by: Simon Pasquier <spasquie@redhat.com>
* Allow limiting maximum number of alerts in webhook The webhook notifier is the only notifier that does not allow templating on the Alertmanager side. Users who encounter occasional alert storms (10ks of alerts going off at once for the same group) have reported webhook receiver systems not being able to cope with the load caused by the resulting large webhook notifier messages (the alerting rules also contained large annotations that can't be stripped away due to lack of templating). Reducing group size also wasn't an option, but this change proposes to allow truncating the list of alerts sent in the webhook body to a provided maximum length. This assumes that e.g. if a group receives 20k alerts, you really are fine only receiving 10k because you wouldn't be able to check them all anyway. Signed-off-by: Julius Volz <julius.volz@gmail.com> * Change max_alerts to uint32 Signed-off-by: Julius Volz <julius.volz@gmail.com> * Add truncatedAlerts field to webhook message Signed-off-by: Julius Volz <julius.volz@gmail.com> * Fix JSON struct tag Signed-off-by: Julius Volz <julius.volz@gmail.com>
* notify: improve logs on notification errors Alertmanager can experience occasional failures when sending notifications to an external service. If the operation succeeds after some retry, the 'alertmanager_notifications_failed_total' metric increases but nothing is logged (unless running with log.level=debug). Hence an operator might receive an alert about notification failures but wouldn't know which integration was failing. With this change, notification failures are logged at the warning level. To avoid log flooding, similar failures on retries aren't logged. Additional information on the failing integration has also been added. Signed-off-by: Simon Pasquier <spasquie@redhat.com> * Log notify success at info level if it's a retry Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
.circleci/config.yml: bump Prometheus orb version
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
* Add suport for s390x Signed-off-by: Nayana <nthorat@us.ibm.com> * Added s390x support to docker image Signed-off-by: vitthalb@us.ibm.com <vitthalb@us.ibm.com> Co-authored-by: Nayana <nthorat@us.ibm.com>
Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
* Release 0.20 docs (prometheus#2292) * Raw docs imports Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Adapt for this repository Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Add max alerts doc Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu> * Remove HipChat from docs Signed-off-by: Julien Pivotto <roidelapluie@inuits.eu>
By default the library implementing the back-off timer stops the timer after 15 minutes. Since the code never checked the value returned by the ticker, notification retries were executed without delay after the 15 minutes had elapsed (e.g. for `group_interval` greater than 15m). This change ensures that the back-off timer never expires. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
v0.21.0 Signed-off-by: Simon Pasquier <spasquie@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
🎉
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilic, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: dislbenn <dbennett@redhat.com> Signed-off-by: dislbenn <dbennett@redhat.com>
Diff between v0.21.0 upstream and this PR:
https://github.com/prometheus/alertmanager/compare/v0.21.0...simonpasquier:aos-bump-0.21.0?diff=unified