Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing openshift-builder-master.yaml to use dockerfile from ocp-build-data #10855

Closed
wants to merge 1 commit into from
Closed

Fixing openshift-builder-master.yaml to use dockerfile from ocp-build-data #10855

wants to merge 1 commit into from

Conversation

alvaroaleman
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2020
adambkaplan
adambkaplan approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
adambkaplan
adambkaplan reviewed Aug 11, 2020
View reviewed changes
Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm cancel

@alvaroaleman @gabemontero can we review why we were using the rhel8 Dockerfile in ocp-build-data?

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Contributor

/lgtm cancel

@alvaroaleman @gabemontero can we review why we were using the rhel8 Dockerfile in ocp-build-data?

it stems from @yselkowitz 's ubi8 migration efforts .... aside from his PR openshift/builder#165
he has this note in https://docs.google.com/document/d/13QoTt78qyGm08D_f6K8pj9xlH7cG721yj-G5BwBzgZY/edit?ts=5f0dbcb1#

builder: sysvinit-tools -> procps-ng/util-linux

@alvaroaleman
Copy link
Contributor Author

Yeah there is currently an ongoing effort to make everything UBI 8 based. @jupierce can provide more details on that.

@adambkaplan
Copy link
Contributor

/test pj-rehearse

@adambkaplan adambkaplan mentioned this pull request Aug 11, 2020
Merged
@adambkaplan
Copy link
Contributor

/close

Replacing with #10917

@openshift-ci-robot
Copy link
Contributor

@adambkaplan: Closed this PR.

In response to this:

/close

Replacing with #10917

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adambkaplan adambkaplan adambkaplan approved these changes

@coreydaley coreydaley Awaiting requested review from coreydaley

Assignees

@adambkaplan adambkaplan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files.
Projects
None yet
Milestone
No milestone
4 participants
@alvaroaleman @openshift-ci-robot @gabemontero @adambkaplan