Increasing the requested resource cpu #11695
Conversation
|
/retest |
|
/lgtm |
|
/approve |
1 similar comment
|
/approve |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
| @@ -34,7 +34,7 @@ tests: | |||
| from: oc-bin-image | |||
| resources: | |||
| requests: | |||
| cpu: "2" | |||
There was a problem hiding this comment.
Isn’t this reducing the resources? From 2 to 800m? 800m means millicpus so effectively .8. Can we not reduce 2 to 800m?
There was a problem hiding this comment.
This shows that the periodic job gets 2 cpus but the CI just gets 200m, so we can keep the 2 cpu in periodic job or increase that? But definitely increase the 200m in standard jobs
There was a problem hiding this comment.
Isn’t this reducing the resources? From 2 to 800m? 800m means millicpus so effectively .8. Can we not reduce 2 to 800m?
@girishramnani So as per our discussion on slack 800m is enough cpu limit for our test to run, right? Isn't it be ok if we reduce the resources according to our consumption.
There was a problem hiding this comment.
I don’t want to unnecessarily change what’s already set. So let’s increase the 200m to 800m and keep the 2 cpu as is
| @@ -35,7 +35,7 @@ tests: | |||
| from: oc-bin-image | |||
| resources: | |||
| requests: | |||
| cpu: "2" | |||
| cpu: 800m | |||
| memory: 4Gi | |||
There was a problem hiding this comment.
May be you can increase the memory to 6Gi to avoid pod rollout issue
prietyc123
force-pushed
the
IncreaseResourceAllocation
branch
from
cc196ad
to
4b1fe16
Compare
|
/lgtm |
|
As per the commit b7c2ffb /unhold |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amitkrout, cdrage, girishramnani, prietyc123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@prietyc123: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Increasing the resource to make sure it is not one of the reason for deployment rollout as suspected in issue redhat-developer/odo#3256
ping @amitkrout