Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci-operator/jobs/openshift/release: Fix 4.4 -> 4.6 in chained update #13019

Closed
wants to merge 2 commits into from
Closed

ci-operator/jobs/openshift/release: Fix 4.4 -> 4.6 in chained update #13019

wants to merge 2 commits into from

Conversation

wking
Copy link
Member

@wking wking commented Oct 22, 2020

Skip 4.3 and start with 4.4, instead of expecting a 4.4 -> 4.6 hop to work. Fixes a typo from the file's creation in 7228c7b (#8532), CC @droslean.

@wking
ci-operator/jobs/openshift/release: Fix 4.4 -> 4.6 in chained update
0e203ff 
Skip 4.3 and start with 4.4, instead of expecting a 4.4 -> 4.6 hop to
work.  Fixes a typo from the file's creation in 7228c7b
(release-controller: branch for 4.7, 2020-04-23, openshift#8532).
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
To complete the pull request process, please assign bbguimaraes after the PR has been reviewed.
You can assign the PR to them by writing /assign @bbguimaraes in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking
Copy link
Member Author

wking commented Oct 22, 2020

Will need #13018 to actually pass.

This was referenced Oct 22, 2020
Merged
Closed
@petr-muller
Copy link
Member

petr-muller commented Oct 23, 2020 •
edited

/retest
(#13018 is in)

@wking
Copy link
Member Author

wking commented Oct 23, 2020

rehearsal:

{"component":"entrypoint","file":"prow/entrypoint/run.go:165","func":"k8s.io/test-infra/prow/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 4h0m0s timeout","severity":"error","time":"2020-10-23T15:50:19Z"} 
time="2020-10-23T15:50:19Z" level=info msg="Received signal." signal=interrupt
2020/10/23 15:50:19 error: Process interrupted with signal interrupt, cancelling execution...
2020/10/23 15:50:19 cleanup: Deleting release pod release-images-initial
2020/10/23 15:50:19 cleanup: Deleting release pod release-images-latest
2020/10/23 15:50:19 cleanup: Deleting template e2e-aws-upgrade
2020/10/23 15:50:19 error: Could not delete template instance: context canceled
{"component":"entrypoint","file":"prow/entrypoint/run.go:250","func":"k8s.io/test-infra/prow/entrypoint.gracefullyTerminate","level":"error","msg":"Process did not exit before 30m0s grace period","severity":"error","time":"2020-10-23T16:20:19Z"}

I've pushed 7639a4c400d62 with an exec to simplify SIGTERM handling.

@wking
ci-operator/jobs/openshift/release: 'exec' ci-operator in 4.7's chain…
cdc7d60 
…ed update test

We are currently timing these out:

  $ curl -s https://storage.googleapis.com/origin-ci-test/pr-logs/pull/openshift_release/13019/rehearse-13019-release-openshift-origin-installer-e2e-aws-upgrade-4.4-to-4.5-to-4.6-to-4.7-ci/1319606966804287488/build-log.txt | tail
  2020/10/23 11:51:41 Running pod e2e-aws-upgrade
  2020/10/23 12:24:35 Container setup in pod e2e-aws-upgrade completed successfully
  {"component":"entrypoint","file":"prow/entrypoint/run.go:165","func":"k8s.io/test-infra/prow/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 4h0m0s timeout","severity":"error","time":"2020-10-23T15:50:19Z"}
  time="2020-10-23T15:50:19Z" level=info msg="Received signal." signal=interrupt
  2020/10/23 15:50:19 error: Process interrupted with signal interrupt, cancelling execution...
  2020/10/23 15:50:19 cleanup: Deleting release pod release-images-initial
  2020/10/23 15:50:19 cleanup: Deleting release pod release-images-latest
  2020/10/23 15:50:19 cleanup: Deleting template e2e-aws-upgrade
  2020/10/23 15:50:19 error: Could not delete template instance: context canceled
  {"component":"entrypoint","file":"prow/entrypoint/run.go:250","func":"k8s.io/test-infra/prow/entrypoint.gracefullyTerminate","level":"error","msg":"Process did not exit before 30m0s grace period","severity":"error","time":"2020-10-23T16:20:19Z"}

I suspect something funny with SIGTERM propagation, and exec'ing
ci-operator will remove one layer of shell process from the signal
chain.
@openshift-merge-robot
Copy link
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/release-openshift-origin-installer-e2e-aws-upgrade-4.4-to-4.5-to-4.6-to-4.7-ci cdc7d60 link /test pj-rehearse
ci/prow/pj-rehearse cdc7d60 link /test pj-rehearse
ci/prow/secret-generator-config-valid cdc7d60 link /test secret-generator-config-valid

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2021
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 10, 2021
@openshift-bot
Copy link
Contributor

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droslean droslean Awaiting requested review from droslean

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
5 participants
@wking @openshift-ci-robot @petr-muller @openshift-merge-robot @openshift-bot