Skip to content

ci-operator/jobs/openshift/release: Fix '["pullSpec")' typos#13018

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:4.7-chain-pullSpec-typo
Oct 23, 2020
Merged

ci-operator/jobs/openshift/release: Fix '["pullSpec")' typos#13018
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
wking:4.7-chain-pullSpec-typo

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Oct 22, 2020

These snuck in with 787549f (#11694), CC @eparis

These snuck in with 787549f (Switch python print statements to be
python2/python3 compatible, 2020-09-08, openshift#11694).
@wking
Copy link
Copy Markdown
Member Author

wking commented Oct 22, 2020

Might need #13019 to actually pass.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

@wking: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/release-openshift-origin-installer-e2e-aws-upgrade-4.3-to-4.4-to-4.6-to-4.7-ci b506b59 link /test pj-rehearse
ci/prow/pj-rehearse b506b59 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@wking
Copy link
Copy Markdown
Member Author

wking commented Oct 22, 2020

Rehearsal:

$ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/13018/rehearse-13018-release-openshift-origin-installer-e2e-aws-upgrade-4.3-to-4.4-to-4.6-to-4.7-ci/1319147337016152064/artifacts/e2e-aws-upgrade/clusterversion.json | jq -r '.items[].status.history[].version'
4.5.16
4.3.40

So it ran, which is enough to merge this. The 4.3-> 4.5 jump is getting fixed separately in #13019.

@wking
Copy link
Copy Markdown
Member Author

wking commented Oct 22, 2020

/assign @petr-muller

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 23, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: petr-muller, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2ee819e into openshift:master Oct 23, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@wking: Updated the following 2 configmaps:

  • job-config-4.7 configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-release-release-4.7-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.7-periodics.yaml
  • job-config-4.7 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-release-4.7-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-release-4.7-periodics.yaml
Details

In response to this:

These snuck in with 787549f (#11694), CC @eparis

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the 4.7-chain-pullSpec-typo branch October 23, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants