Bug 1882785: Clean-up leased environments and detect broken state before running remote libvirt jobs. #14479
Conversation
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/lgtm |
jaypoulz
changed the title
openshift-ci-robot
added
the
bugzilla/severity-low
|
@jaypoulz: This pull request references Bugzilla bug 1882785, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
|
@jaypoulz: This pull request references Bugzilla bug 1882785, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
jaypoulz
force-pushed
the
jpz-ensure-clean-env-for-remote-libvirt-jobs
branch
from
8e9264d
to
b480fab
Compare
jaypoulz
force-pushed
the
jpz-ensure-clean-env-for-remote-libvirt-jobs
branch
8 times, most recently
from
988d364
to
d8739b2
Compare
|
@jaypoulz: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
jaypoulz
force-pushed
the
jpz-ensure-clean-env-for-remote-libvirt-jobs
branch
from
d8739b2
to
a4caf1a
Compare
|
/unhold |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/assign @mandre This has been tested in previous patches. The last edit is simply a rebase of what was working before minus a few debug statements. It would be valuable to get this in before shutdown since it will help keep our environments clean even when we're not actively monitoring them. |
|
/lgtm |
ci-operator/templates/openshift/installer/cluster-launch-installer-remote-libvirt-e2e.yaml
Show resolved
Hide resolved
ci-operator/templates/openshift/installer/cluster-launch-installer-remote-libvirt-e2e.yaml
Outdated
Show resolved
Hide resolved
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
jaypoulz
force-pushed
the
jpz-ensure-clean-env-for-remote-libvirt-jobs
branch
from
a4caf1a
to
2a64937
Compare
…emote libvirt jobs. The goal of this PR is to make no assumptions about the state of the environment lease when you get it. This allows us to detect a bad state or connection issues to the environment before we start running the job. It will also remove the need for manual clean-up of bad jobs since our job environments will be self-pruning. We know that the max length of our infra names are 21 characters, so we use this knowledge to ensure we can inject the DNS records into the right network.
jaypoulz
force-pushed
the
jpz-ensure-clean-env-for-remote-libvirt-jobs
branch
from
3f74537
to
8634bf5
Compare
|
/unhold Latest commit was tested, but rebased for clean-up purposes. All review feedback should be implemented. |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hamzy, jaypoulz, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@jaypoulz: All pull requests linked via external trackers have merged: Bugzilla bug 1882785 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@jaypoulz: Updated the following 5 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Since our environments are controlled via leases, a job with a lease knows that it should own its space upon acquiring that lease.
This allows us to remove any old conflicting resources (as long as we now identify those resources using the lease name), and verify that the state of the lease is clean before even attempting an install.