Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-services/prow/02_config/_plugins.yaml: openshift-psap/ci-artifacts: require_self_approval: true #16330

Merged
merged 1 commit into from Mar 1, 2021

Conversation

kpouget
Copy link
Contributor

@kpouget kpouget commented Mar 1, 2021

With this PR, I would like to make "self approval" mandatory on the openshift-psap/ci-artifacts, in order to prevent the automatic merging of PR once the \lgtm is received. Instead, the owner of the PR has to "approve" the PR to trigger the bot-mergin.

I am not 100% sure that the patch is correct, let me know if it doesn't match what I described above :)

@kpouget
Copy link
Contributor Author

kpouget commented Mar 1, 2021

@ArangoGutierrez PTAL, we discussed it on Slack a few weeks ago

@ArangoGutierrez
Copy link
Contributor

/assign @stevekuznetsov
/Lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 1, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, ArangoGutierrez, kpouget

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2021
@openshift-merge-robot openshift-merge-robot merged commit bacea84 into openshift:master Mar 1, 2021
@openshift-ci-robot
Copy link
Contributor

@kpouget: Updated the following 2 configmaps:

  • plugins configmap in namespace ci at cluster api.ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml
  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key plugins.yaml using file core-services/prow/02_config/_plugins.yaml

In response to this:

With this PR, I would like to make "self approval" mandatory on the openshift-psap/ci-artifacts, in order to prevent the automatic merging of PR once the \lgtm is received. Instead, the owner of the PR has to "approve" the PR to trigger the bot-mergin.

I am not 100% sure that the patch is correct, let me know if it doesn't match what I described above :)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kpouget kpouget deleted the approve branch March 4, 2021 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
6 participants