Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use golang-1.14 for image-registry 4.6 #16912

Merged

Conversation

dmage
Copy link
Member

@dmage dmage commented Mar 17, 2021

library-go 4.6 needs go 1.14

openshift/image-registry#269

@dmage
Copy link
Member Author

dmage commented Mar 17, 2021

/assign @ricardomaraschini

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2021
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4eec2e2 into openshift:master Mar 18, 2021
@openshift-ci-robot
Copy link
Contributor

@dmage: Updated the ci-operator-4.6-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-image-registry-release-4.6.yaml using file ci-operator/config/openshift/image-registry/openshift-image-registry-release-4.6.yaml

In response to this:

library-go 4.6 needs go 1.14

openshift/image-registry#269

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants