Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1946694: Run remote registries for pull-through tests as pods #269

Merged
merged 4 commits into from Apr 10, 2021
Merged

Bug 1946694: Run remote registries for pull-through tests as pods #269

merged 4 commits into from Apr 10, 2021

Conversation

dmage
Copy link
Member

@dmage dmage commented Mar 17, 2021 •
edited

Backport of #258 + #259.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 17, 2021 •
edited

@dmage: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

IR-172: Run remote registries for pull-through tests as pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2021
@dmage dmage mentioned this pull request Mar 17, 2021
Merged
@dmage
Copy link
Member Author

dmage commented Mar 21, 2021

/retest

1 similar comment
@dmage
Copy link
Member Author

dmage commented Mar 25, 2021

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 25, 2021 •
edited

@dmage: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

IR-172: Run remote registries for pull-through tests as pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ricardomaraschini @dmage
Polling route until registry is available
03f0626 
Following messages from networking team we should ping the route until
it becomes available, apparently that is the only way of begin certain
that it is properly set up.

Networking team uses the following script to achieve the same on their
tests:

https://github.com/openshift/origin/blob/master/test/extended/router/scoped.go#L241-L271
@dmage
Copy link
Member Author

dmage commented Mar 26, 2021

/assign @ricardomaraschini

ricardomaraschini
ricardomaraschini approved these changes Mar 26, 2021
View reviewed changes
Copy link
Contributor

@ricardomaraschini ricardomaraschini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmage, ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dmage dmage changed the title IR-172: Run remote registries for pull-through tests as pods Bug 1946694: Run remote registries for pull-through tests as pods Apr 6, 2021
@openshift-ci-robot
Copy link
Contributor

@dmage: An error was encountered querying GitHub for users with public email (wzheng@redhat.com) for bug 1946694 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

Bug 1946694: Run remote registries for pull-through tests as pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmage
Copy link
Member Author

dmage commented Apr 6, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@dmage: An error was encountered querying GitHub for users with public email (wzheng@redhat.com) for bug 1946694 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dmage
Copy link
Member Author

dmage commented Apr 6, 2021

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@dmage: An error was encountered querying GitHub for users with public email (wzheng@redhat.com) for bug 1946694 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alvaroaleman
Copy link

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@alvaroaleman: An error was encountered querying GitHub for users with public email (wzheng@redhat.com) for bug 1946694 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. Post "http://ghproxy/graphql": dial tcp 172.30.229.2:80: i/o timeout

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alvaroaleman
Copy link

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@alvaroaleman: An error was encountered querying GitHub for users with public email (wzheng@redhat.com) for bug 1946694 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message. non-200 OK status code: 403 Forbidden body: "{\n \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#abuse-rate-limits\",\n \"message\": \"You have triggered an abuse detection mechanism. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@alvaroaleman
Copy link

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 6, 2021
@openshift-ci-robot
Copy link
Contributor

@alvaroaleman: This pull request references Bugzilla bug 1946694, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.z) matches configured target release for branch (4.6.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1905502 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1905502 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0, 4.7.z
  • bug has dependents

Requesting review from QA contact:
/cc @wzheng1

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@russellb russellb added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 9, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 9, 2021 •
edited

@dmage: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/integration d0a9f7d link /test integration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5077c16 into openshift:release-4.6 Apr 10, 2021
@openshift-ci-robot
Copy link
Contributor

@dmage: All pull requests linked via external trackers have merged:

Bugzilla bug 1946694 has been moved to the MODIFIED state.

In response to this:

Bug 1946694: Run remote registries for pull-through tests as pods

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricardomaraschini ricardomaraschini ricardomaraschini approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@wzheng1 wzheng1 Awaiting requested review from wzheng1

Assignees

@ricardomaraschini ricardomaraschini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dmage @openshift-ci-robot @alvaroaleman @openshift-bot @ricardomaraschini @russellb @openshift-merge-robot