Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1954830: api: fix verify-client-go for release branches #18158

Merged

Conversation

staebler
Copy link
Contributor

Fix the openshift/api verify-client-go job for the 4.7, 4.8, and 4.9 release jobs so that the openshift/client-go branch that is used is the branch corresponding to the openshift/api branch being tested.

Fix the openshift/api verify-client-go job for the 4.7, 4.8, and 4.9
release jobs so that the openshift/client-go branch that is used
is the branch corresponding to the openshift/api branch being tested.
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Apr 28, 2021
@openshift-ci-robot
Copy link
Contributor

@staebler: This pull request references Bugzilla bug 1954830, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1954830: api: fix verify-client-go for release branches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 28, 2021
@deads2k
Copy link
Contributor

deads2k commented Apr 28, 2021

/lgtm
/approve

@staebler
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@staebler: This pull request references Bugzilla bug 1954830, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @xingxingxia

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 28, 2021
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, staebler

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@openshift-merge-robot openshift-merge-robot merged commit 15a0411 into openshift:master Apr 28, 2021
@openshift-ci-robot
Copy link
Contributor

@staebler: All pull requests linked via external trackers have merged:

Bugzilla bug 1954830 has been moved to the MODIFIED state.

In response to this:

Bug 1954830: api: fix verify-client-go for release branches

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@staebler: Updated the following 3 configmaps:

  • ci-operator-4.7-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-api-release-4.7.yaml using file ci-operator/config/openshift/api/openshift-api-release-4.7.yaml
  • ci-operator-4.8-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-api-release-4.8.yaml using file ci-operator/config/openshift/api/openshift-api-release-4.8.yaml
  • ci-operator-4.9-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-api-release-4.9.yaml using file ci-operator/config/openshift/api/openshift-api-release-4.9.yaml

In response to this:

Fix the openshift/api verify-client-go job for the 4.7, 4.8, and 4.9 release jobs so that the openshift/client-go branch that is used is the branch corresponding to the openshift/api branch being tested.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
4 participants