Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1948585: Add periodic for OVN using local gw mode #18322

Merged
merged 1 commit into from May 13, 2021
Merged

Bug 1948585: Add periodic for OVN using local gw mode #18322

merged 1 commit into from May 13, 2021

Conversation

jluhrsen
Copy link
Contributor

@jluhrsen jluhrsen commented May 4, 2021

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen
To complete the pull request process, please assign danwinship, joelsmith after the PR has been reviewed.
You can assign the PR to them by writing /assign @danwinship @joelsmith in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 4, 2021

/retitle Bug 1948585: Add periodic for OVN using local gw mode

@openshift-ci-robot openshift-ci-robot changed the title Add periodic for OVN using local gw mode Bug 1948585: Add periodic for OVN using local gw mode May 4, 2021
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 4, 2021
@openshift-ci-robot
Copy link
Contributor

@jluhrsen: This pull request references Bugzilla bug 1948585, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (anusaxen@redhat.com), skipping review request.

In response to this:

Bug 1948585: Add periodic for OVN using local gw mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 4, 2021
@jluhrsen jluhrsen force-pushed the ovn-local-gw branch 14 times, most recently from 8511862 to 99775ea Compare May 7, 2021 21:23
@jluhrsen
Copy link
Contributor Author

jluhrsen commented May 7, 2021

@trozet , so far so good with the non baremetal job (aws). local is being used and the job passed.

that work didn't apply to the baremetal job though. latest version of this PR is trying to get that figured out.
just fyi.

@jluhrsen jluhrsen force-pushed the ovn-local-gw branch 4 times, most recently from 8229154 to 323a75c Compare May 7, 2021 22:02
@trozet
Copy link
Contributor

trozet commented May 7, 2021

@trozet , so far so good with the non baremetal job (aws). local is being used and the job passed.

that work didn't apply to the baremetal job though. latest version of this PR is trying to get that figured out.
just fyi.

Thanks Jamo. FYI there was a bug in services with local gw mode that @astoycos fixed. I dont think it's downstream yet.

@jluhrsen
Copy link
Contributor Author

/test pj-rehearse

@jluhrsen jluhrsen force-pushed the ovn-local-gw branch 7 times, most recently from 52ec093 to 4b7d57a Compare May 11, 2021 17:39
@jluhrsen
Copy link
Contributor Author

The metal-ipi rehearsals do not work. The config they generate produces something too big for the OS running CI to handle.
but, to check that the changes are working as expected I removed the test steps (baremetalds-e2e-conf and baremetalds-e2e-test)
from the workflow. That reduced the size of the config and the rehearsal ran the important parts I was concerned with.

  1. in the devscripts setup, you can see that it's noting that it needs to override the gateway_mode
  2. in the create cluster log, you can see that it's copying the gateway_mode configMap to the install location.
  3. in the ovnkube master and worker node logs you can see local mode being used

@stbenjam
Copy link
Member

For metal-ipi, typically we add a flag to our development scripts https://github.com/openshift-metal3/dev-scripts, and then set the flag in CI. This would let a developer easily use local gateway mode as well. If we did it this way, then we'd avoid making our scripts even bigger in CI.

@jluhrsen
Copy link
Contributor Author

For metal-ipi, typically we add a flag to our development scripts https://github.com/openshift-metal3/dev-scripts, and then set the flag in CI. This would let a developer easily use local gateway mode as well. If we did it this way, then we'd avoid making our scripts even bigger in CI.

ok, I can try to do it that way. I remember quickly glancing through the dev scripts which is where I found that ASSESTS_EXTRA_FOLDER variable which led me to doing it this way.

@stbenjam, can you help me understand the best way I can test my changes to dev-scripts so I know what I end up with
is actually working? With this PR in release and the rehearsal job hack, I can at least see that my changes are working in
our jobs. I don't have access to any baremetal env and never used the dev-scripts project before.

@jluhrsen
Add periodic for OVN using local gw mode in aws
11c48c2 
Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen
Copy link
Contributor Author

@trozet , let's just use this PR to get OVN + local gw mode working in AWS. I'm guessing it will take me a bit to figure out the right way to a dev-scripts PR to make this happen on baremetal.

@stbenjam
Copy link
Member

For metal-ipi, typically we add a flag to our development scripts https://github.com/openshift-metal3/dev-scripts, and then set the flag in CI. This would let a developer easily use local gateway mode as well. If we did it this way, then we'd avoid making our scripts even bigger in CI.

ok, I can try to do it that way. I remember quickly glancing through the dev scripts which is where I found that ASSESTS_EXTRA_FOLDER variable which led me to doing it this way.

@stbenjam, can you help me understand the best way I can test my changes to dev-scripts so I know what I end up with
is actually working? With this PR in release and the rehearsal job hack, I can at least see that my changes are working in
our jobs. I don't have access to any baremetal env and never used the dev-scripts project before.

You can make the changes you need to dev-scripts, have some flag like OVN_LOCAL_GW. To test it, add a temporary second commit that swaps the default value to true and you can see what CI does.

@jluhrsen
Copy link
Contributor Author

For metal-ipi, typically we add a flag to our development scripts https://github.com/openshift-metal3/dev-scripts, and then set the flag in CI. This would let a developer easily use local gateway mode as well. If we did it this way, then we'd avoid making our scripts even bigger in CI.

ok, I can try to do it that way. I remember quickly glancing through the dev scripts which is where I found that ASSESTS_EXTRA_FOLDER variable which led me to doing it this way.
@stbenjam, can you help me understand the best way I can test my changes to dev-scripts so I know what I end up with
is actually working? With this PR in release and the rehearsal job hack, I can at least see that my changes are working in
our jobs. I don't have access to any baremetal env and never used the dev-scripts project before.

You can make the changes you need to dev-scripts, have some flag like OVN_LOCAL_GW. To test it, add a temporary second commit that swaps the default value to true and you can see what CI does.

👍🏻

working on that here

@jluhrsen
Copy link
Contributor Author

/retest

1 similar comment
@jluhrsen
Copy link
Contributor Author

/retest

@jluhrsen
Copy link
Contributor Author

@trozet this is ready.

these presubmits are never going to fully pass.

the non-local job is using shared
and the local job is using local

@jluhrsen
Copy link
Contributor Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

@jluhrsen: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-virtualmedia 52ec09387694941f09d06f4fc786efb0e69e23f8 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-upgrade 52ec09387694941f09d06f4fc786efb0e69e23f8 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-ovn-dualstack-local-gateway 52ec09387694941f09d06f4fc786efb0e69e23f8 link /test pj-rehearse
ci/rehearse/openshift/router/release-4.9/e2e-metal-ipi-ovn-ipv6 52ec09387694941f09d06f4fc786efb0e69e23f8 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-compact 52ec09387694941f09d06f4fc786efb0e69e23f8 link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/release-4.9/e2e-metal-ipi-ovn-ipv6-ipsec 52ec09387694941f09d06f4fc786efb0e69e23f8 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.8-e2e-metal-ipi-serial-ipv4 4b7d57a8ed280439e0b1e2e201f3164f36245694 link /test pj-rehearse
ci/rehearse/openshift/ovn-kubernetes/release-4.9/e2e-ovn-hybrid-step-registry 11c48c2 link /test pj-rehearse
ci/rehearse/openshift/ovn-kubernetes/release-4.9/e2e-aws-ovn-windows 11c48c2 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-nightly-4.8-e2e-vsphere-ovn 11c48c2 link /test pj-rehearse
ci/rehearse/openshift/ovn-kubernetes/release-4.9/e2e-gcp-ovn 11c48c2 link /test pj-rehearse
ci/rehearse/openshift/cluster-network-operator/release-4.9/e2e-ovn-ipsec-step-registry 11c48c2 link /test pj-rehearse
ci/rehearse/openshift/ovn-kubernetes/release-4.9/e2e-azure-ovn 11c48c2 link /test pj-rehearse
ci/rehearse/openshift/cluster-etcd-operator/release-4.9/e2e-gcp-disruptive-ovn 11c48c2 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.8-upgrade-from-stable-4.7-e2e-aws-ovn-upgrade 11c48c2 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.8-upgrade-from-stable-4.7-e2e-azure-ovn-upgrade 11c48c2 link /test pj-rehearse
ci/rehearse/periodic-ci-openshift-release-master-ci-4.8-upgrade-from-stable-4.7-e2e-gcp-ovn-upgrade 11c48c2 link /test pj-rehearse
ci/prow/pj-rehearse 11c48c2 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knobunc
Copy link
Contributor

knobunc commented May 13, 2021

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2021
@dcbw
Copy link
Contributor

dcbw commented May 13, 2021

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, jluhrsen, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ac2c312 into openshift:master May 13, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

@jluhrsen: All pull requests linked via external trackers have merged:

Bugzilla bug 1948585 has been moved to the MODIFIED state.

In response to this:

Bug 1948585: Add periodic for OVN using local gw mode

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 13, 2021

@jluhrsen: Updated the following 3 configmaps:

  • job-config-master configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-master-periodics.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key ovn-conf-commands.sh using file ci-operator/step-registry/ovn/conf/ovn-conf-commands.sh
    • key ovn-conf-ref.yaml using file ci-operator/step-registry/ovn/conf/ovn-conf-ref.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-master__nightly-4.8.yaml using file ci-operator/config/openshift/release/openshift-release-master__nightly-4.8.yaml

In response to this:

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jluhrsen jluhrsen deleted the ovn-local-gw branch July 22, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmage dmage Awaiting requested review from dmage

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@dcbw dcbw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
7 participants
@jluhrsen @openshift-ci-robot @trozet @stbenjam @knobunc @dcbw @openshift-merge-robot