Require either no-FF labels or valid-bz to merge into builder repo

[bparees]

No description provided.

[bparees]

/assign @alvaroaleman

[bparees]

cc @adambkaplan

[bparees]

@alvaroaleman i'm not totally clear why we have both the massive "exclude branches" query config, as well as specific configs for various branches. In particular it seems like the "exclude branches" query and the "include: master/main" query are duplicative.... could/should we possibly get rid of the "include: master/main" config and just let it be handled by the "exclude" config?

[alvaroaleman]

In particular it seems like the "exclude branches" query and the "include: master/main" query are duplicative.... could/should we possibly get rid of the "include: master/main" config and just let it be handled by the "exclude" config?

Sounds like a good idea, probably an artifact of the unreadability of this config

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• core-services/prow/02_config/openshift/builder/OWNERS [alvaroaleman,bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@bparees: Updated the config configmap in namespace ci at cluster app.ci using the following files:

• key core-services-prow-02_config-openshift-builder-_prowconfig.yaml using file core-services/prow/02_config/openshift/builder/_prowconfig.yaml

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[bparees]

@alvaroaleman since we now have these multiple configs, is that going to cause any problems w/ the automation that adds the valid-bz label requirement at feature freeze, and the group-lead-approval requirement at code freeze, or other config update automation that happens on branching?

[alvaroaleman]

@bparees I wasn't aware any of that is automated as of today, but no, we have code to shard the config during write (because we encountered this issue elsewhere already): https://github.com/openshift/ci-tools/blob/3c036bf311f35b106e749052028ce204bb2d9540/pkg/prowconfigsharding/prowconfigsharding.go