Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release-openshift-origin-installer-launch-ovirt task #21784

Merged
merged 3 commits into from
Sep 20, 2021

Conversation

vrutkovs
Copy link
Member

This adds a task, which would be used by cluster-bot to start an ovirt cluster

Add a new set of leases, limited to 3, for clusterbot clusters
@vrutkovs vrutkovs force-pushed the ovirt-launch-task branch 3 times, most recently from e559fc0 to 5fab100 Compare September 14, 2021 07:59
post:
- chain: ipi-ovirt-post
leases:
- env: OVIRT_UPGRADE_LEASED_RESOURCE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't quite follow how leases work - does it have to be a unique env var?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It basically means that the lease name will be stored in an env var specified by leases.env.
So here what you did means that the lease name will be stored in en env var OVIRT_UPGRADE_LEASED_RESOURCE which will be available for all the steps.
On ovirt we have logic that the leases names correlate to secrets we have, that way we isolate openshift clusters from one another on the oVirt engine.
If you will use the OVIRT_UPGRADE_LEASED_RESOURCE env var, then the test will look for a secret with that name, which will not be there

This uses a different lease and a custom test to wait for cluster-bot commands
This adds a task, which would be used by cluster-bot to run an ovirt cluster
@Gal-Zaidman
Copy link
Contributor

/lgtm

@Gal-Zaidman
Copy link
Contributor

/assign @petr-muller

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 14, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Gal-Zaidman, petr-muller, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021
@openshift-merge-robot openshift-merge-robot merged commit c719b8d into openshift:master Sep 20, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2021

@vrutkovs: Updated the following 3 configmaps:

  • job-config-misc configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-release-infra-periodics.yaml using file ci-operator/jobs/openshift/release/openshift-release-infra-periodics.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/openshift/e2e/ovirt/clusterbot/OWNERS
    • key openshift-e2e-ovirt-clusterbot-workflow.metadata.json using file ci-operator/step-registry/openshift/e2e/ovirt/clusterbot/openshift-e2e-ovirt-clusterbot-workflow.metadata.json
    • key openshift-e2e-ovirt-clusterbot-workflow.yaml using file ci-operator/step-registry/openshift/e2e/ovirt/clusterbot/openshift-e2e-ovirt-clusterbot-workflow.yaml
  • resources configmap in namespace ci at cluster app.ci using the following files:
    • key boskos.yaml using file core-services/prow/02_config/_boskos.yaml

In response to this:

This adds a task, which would be used by cluster-bot to start an ovirt cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants