-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add release-openshift-origin-installer-launch-ovirt task #21784
Add release-openshift-origin-installer-launch-ovirt task #21784
Conversation
e665f10
to
4cce997
Compare
...or/step-registry/openshift/e2e/ovirt/clusterbot/openshift-e2e-ovirt-clusterbot-workflow.yaml
Outdated
Show resolved
Hide resolved
...or/step-registry/openshift/e2e/ovirt/clusterbot/openshift-e2e-ovirt-clusterbot-workflow.yaml
Outdated
Show resolved
Hide resolved
...or/step-registry/openshift/e2e/ovirt/clusterbot/openshift-e2e-ovirt-clusterbot-workflow.yaml
Outdated
Show resolved
Hide resolved
...or/step-registry/openshift/e2e/ovirt/clusterbot/openshift-e2e-ovirt-clusterbot-workflow.yaml
Show resolved
Hide resolved
Add a new set of leases, limited to 3, for clusterbot clusters
e559fc0
to
5fab100
Compare
post: | ||
- chain: ipi-ovirt-post | ||
leases: | ||
- env: OVIRT_UPGRADE_LEASED_RESOURCE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The env needs to be:
OVIRT_CLUSTERBOT_LEASED_RESOURCE
The OVIRT_UPGRADE_LEASED_RESOURCE
has specific logic here https://github.com/openshift/release/blob/master/ci-operator/step-registry/ipi/conf/ovirt/generate-install-config-params/ipi-conf-ovirt-generate-install-config-params-commands.sh#L13
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't quite follow how leases work - does it have to be a unique env var?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It basically means that the lease name will be stored in an env var specified by leases.env.
So here what you did means that the lease name will be stored in en env var OVIRT_UPGRADE_LEASED_RESOURCE
which will be available for all the steps.
On ovirt we have logic that the leases names correlate to secrets we have, that way we isolate openshift clusters from one another on the oVirt engine.
If you will use the OVIRT_UPGRADE_LEASED_RESOURCE
env var, then the test will look for a secret with that name, which will not be there
...or/step-registry/openshift/e2e/ovirt/clusterbot/openshift-e2e-ovirt-clusterbot-workflow.yaml
Outdated
Show resolved
Hide resolved
5fab100
to
58689f3
Compare
This uses a different lease and a custom test to wait for cluster-bot commands
This adds a task, which would be used by cluster-bot to run an ovirt cluster
58689f3
to
d4d92d6
Compare
/lgtm |
/assign @petr-muller |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gal-Zaidman, petr-muller, vrutkovs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@vrutkovs: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This adds a task, which would be used by cluster-bot to start an ovirt cluster