Bug 2006947: add optional e2e-aws-proxy to samples operator master branch #22168
Conversation
openshift-ci
bot
added
bugzilla/severity-medium
|
@gabemontero: This pull request references Bugzilla bug 2006947, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
e2e-aws-proxy will pass after openshift/cluster-samples-operator#397 merges |
|
hmm ....e2e-aws-proxy passed perhaps I have not configured the job in the same way as the failing periodic? investigating |
|
not seeing anything obviously wrong with the new e2e-aws-proxy job as compared to the nightly periodic see https://bugzilla.redhat.com/show_bug.cgi?id=2006947#c3 for tldr /assign @adambkaplan let's get this merged and I'll start creating test PRs in builder and cluster samples operator to vet depending on how things sort out, I'll circle back to updating non-master branches |
|
/hold got assistance from @petr-muller |
openshift-ci
bot
added
the
do-not-merge/hold
gabemontero
force-pushed
the
add-proxy-e2e-samples
branch
from
d0cdcda
to
6d93ffd
Compare
openshift-ci
bot
removed
the
approved
|
OK NOW we are getting errors that are induced by Bug 2006947 openshift/builder e2e-aws-proxy https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/22168/rehearse-22168-pull-ci-openshift-builder-master-e2e-aws-proxy/1441051837330362368 is a repro, with samples bootstrapping as removed and the build tests that need the sample imagestreams are failling |
|
@gabemontero: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
…use proxy profile (hoping we do not need to union builds/proxy profile into a new profile
gabemontero
force-pushed
the
add-proxy-e2e-samples
branch
from
6d93ffd
to
04aadf9
Compare
|
/hold cancel @adambkaplan @coreydaley note the master/4.10 branch rehearsals will fail until the samples operator fix with this BZ merges but I want to test that fix with the e2e-aws-proxy this PR will provide before it merges so we need to merge this despite master/4.10 branch failures however, the fixes to for the builder and OCM repos in releases 4.6 - 4.9 should provide suitable validation that simply switching to the proxy workflow is OK |
openshift-ci
bot
removed
the
do-not-merge/hold
| workflow: openshift-e2e-aws-builds | ||
| workflow: openshift-e2e-aws-proxy |
There was a problem hiding this comment.
interesting - our proxy tests were not in fact running behind a proxy!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
approved
|
@gabemontero: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Once unlinked, request a bug refresh with Bugzilla bug 2006947 has not been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gabemontero: Updated the following 8 configmaps:
In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
shoot @adambkaplan it looks like the bot took your approve and added the lgtm? the rehearsals were still cooking when this merged I'll continue to inspect the rehearsals for any unexpected problems .... if their statuses are never reported, we probably should create some test PRs to make sure we are OK with builder/openshift-controller-manager |
|
looks like the rehearsals were terminated when the PR merged I'll sanity check in openshift/cluster-samples-operator#397 followed by a test PR in build and OCM @adambkaplan |
No description provided.