Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hypershift: Use maketarget from repo for CI installation #23274

Merged
merged 2 commits into from
Nov 3, 2021

Conversation

alvaroaleman
Copy link
Contributor

This allows to atomically change code and install command by versioning
them both in the hypershift repo rather than versioning the latter here.

Requires openshift/hypershift#635 to merge first
/hold
/assign @csrwng

Ref https://issues.redhat.com/browse/HOSTEDCP-257

This allows to atomically change code and install command by versioning
them both in the hypershift repo rather than versioning the latter here.
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2021
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2021
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csrwng
Copy link
Contributor

csrwng commented Nov 3, 2021

/hold

@alvaroaleman
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2021
@openshift-merge-robot openshift-merge-robot merged commit 99390fa into openshift:master Nov 3, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 3, 2021

@alvaroaleman: Updated the ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:

  • key openshift-hypershift-main.yaml using file ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml

In response to this:

This allows to atomically change code and install command by versioning
them both in the hypershift repo rather than versioning the latter here.

Requires openshift/hypershift#635 to merge first
/hold
/assign @csrwng

Ref https://issues.redhat.com/browse/HOSTEDCP-257

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
3 participants