Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add periodic jobs for kubernetes-nmstate #25346

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Add periodic jobs for kubernetes-nmstate #25346

merged 2 commits into from
Jan 24, 2022

Conversation

creydr
Copy link
Member

@creydr creydr commented Jan 17, 2022

Adds periodic jobs to run the e2e test of kubernetes-nmstate against the current release and nightly builds.

In addition this PR adds the k-nmstate e2e tests as a workflow, so it can be reused (ca47dbf).

@creydr
Add workflow to run kubernetes-nmstate e2e tests
ca47dbf 
Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@creydr
Add periodic jobs for kubernetes-nmstate
07583ad 
Adds periodic jobs to run the e2e test of kubernetes-nmstate against the
current release and nightly builds.

Signed-off-by: Christoph Stäbler <cstabler@redhat.com>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 17, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 17, 2022
@creydr
Copy link
Member Author

creydr commented Jan 17, 2022

/test all

@creydr creydr mentioned this pull request Jan 17, 2022
Closed
@creydr
Copy link
Member Author

creydr commented Jan 17, 2022

/test pj-rehearse

1 similar comment
@creydr
Copy link
Member Author

creydr commented Jan 18, 2022

/test pj-rehearse

@creydr creydr marked this pull request as ready for review January 18, 2022 10:29
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 18, 2022
@creydr
Copy link
Member Author

creydr commented Jan 18, 2022

/assign @cybertron

@creydr
Copy link
Member Author

creydr commented Jan 18, 2022

/test pj-rehearse

@cybertron
Copy link
Member

It looks like the cluster is failing to stand up in the nightly job, and I see in forum-metal-platform that the 4.10 release is red. This may be failing on something unrelated.

Otherwise it lgtm.

@creydr
Copy link
Member Author

creydr commented Jan 18, 2022

It looks like the cluster is failing to stand up in the nightly job, and I see in forum-metal-platform that the 4.10 release is red. This may be failing on something unrelated.

Otherwise it lgtm.

Yes seems so. I will retest tomorrow (passed already a couple of times https://prow.ci.openshift.org/job-history/gs/origin-ci-test/pr-logs/directory/rehearse-25346-periodic-ci-openshift-kubernetes-nmstate-master-e2e-sdn-ipv4-nightly-periodic)

@creydr
Copy link
Member Author

creydr commented Jan 19, 2022

/test pj-rehearse

@creydr
Copy link
Member Author

creydr commented Jan 19, 2022

@cybertron: the nightly passed. Could you PTAL again?

@cybertron
Copy link
Member

/lgtm

\o/

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2022
@cybertron
Copy link
Member

/assign @jupierce

@creydr
Copy link
Member Author

creydr commented Jan 21, 2022

@jupierce could you PTAL at this PR?
Thanks in advance

@creydr
Copy link
Member Author

creydr commented Jan 24, 2022

/assign @alvaroaleman

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alvaroaleman, creydr, cybertron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@creydr: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d743ade into openshift:master Jan 24, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 24, 2022

@creydr: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kubernetes-nmstate-master.yaml using file ci-operator/config/openshift/kubernetes-nmstate/openshift-kubernetes-nmstate-master.yaml
  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-kubernetes-nmstate-master-periodics.yaml using file ci-operator/jobs/openshift/kubernetes-nmstate/openshift-kubernetes-nmstate-master-periodics.yaml
  • step-registry configmap in namespace ci at cluster app.ci using the following files:
    • key OWNERS using file ci-operator/step-registry/kubernetes-nmstate/OWNERS
    • key OWNERS using file ci-operator/step-registry/kubernetes-nmstate/e2e/OWNERS
    • key kubernetes-nmstate-e2e-commands.sh using file ci-operator/step-registry/kubernetes-nmstate/e2e/kubernetes-nmstate-e2e-commands.sh
    • key kubernetes-nmstate-e2e-ref.metadata.json using file ci-operator/step-registry/kubernetes-nmstate/e2e/kubernetes-nmstate-e2e-ref.metadata.json
    • key kubernetes-nmstate-e2e-ref.yaml using file ci-operator/step-registry/kubernetes-nmstate/e2e/kubernetes-nmstate-e2e-ref.yaml
    • key kubernetes-nmstate-e2e-workflow.metadata.json using file ci-operator/step-registry/kubernetes-nmstate/e2e/kubernetes-nmstate-e2e-workflow.metadata.json
    • key kubernetes-nmstate-e2e-workflow.yaml using file ci-operator/step-registry/kubernetes-nmstate/e2e/kubernetes-nmstate-e2e-workflow.yaml

In response to this:

Adds periodic jobs to run the e2e test of kubernetes-nmstate against the current release and nightly builds.

In addition this PR adds the k-nmstate e2e tests as a workflow, so it can be reused (ca47dbf).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@creydr creydr deleted the add-stable-and-nightly-periodic-jobs-for-kubernetes-nmstate-2 branch February 21, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alvaroaleman alvaroaleman alvaroaleman approved these changes

@droslean droslean Awaiting requested review from droslean

@phoracek phoracek Awaiting requested review from phoracek

Assignees

@cybertron cybertron

@alvaroaleman alvaroaleman

@jupierce jupierce

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
5 participants
@creydr @cybertron @alvaroaleman @jupierce @openshift-merge-robot