Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove csi-operator image job #3146

Merged
merged 1 commit into from
Mar 19, 2019

Conversation

jsafrane
Copy link
Contributor

csi-operator is not shipped as part of OKD, so don't build its image.

csi-operator is not shipped as part of OKD.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 19, 2019
@tsmetana
Copy link
Member

Don't you need to also update cluster/ci/config/prow/config.yaml and cluster/ci/config/prow/plugins.yaml?

@jsafrane
Copy link
Contributor Author

Don't you need to also update cluster/ci/config/prow/config.yaml and cluster/ci/config/prow/plugins.yaml?

No, I still want /lgtm and merge bot working in the repo.

@tsmetana
Copy link
Member

OK then.
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, tsmetana

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 42eb8da into openshift:master Mar 19, 2019
@openshift-ci-robot
Copy link
Contributor

@jsafrane: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-csi-operator-master.yaml using file ci-operator/config/openshift/csi-operator/openshift-csi-operator-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-csi-operator-master.yaml using file ci-operator/config/openshift/csi-operator/openshift-csi-operator-master.yaml
  • job-config-master configmap in namespace ci using the following files:
    • key openshift-csi-operator-master-postsubmits.yaml using file ``
    • key openshift-csi-operator-master-presubmits.yaml using file ci-operator/jobs/openshift/csi-operator/openshift-csi-operator-master-presubmits.yaml

In response to this:

csi-operator is not shipped as part of OKD, so don't build its image.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

@jsafrane: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/csi-operator/master/e2e-aws bebb9e4 link /test pj-rehearse
ci/prow/pj-rehearse bebb9e4 link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Contributor Author

@petr-muller @bbguimaraes @droslean, did we break anything with ^?

The goal is to remove images and e2e-aws jobs and leave the other jobs there.

@petr-muller
Copy link
Member

petr-muller commented Mar 20, 2019

did we break anything with ^?
The goal is to remove images and e2e-aws jobs and leave the other jobs there.

@jsafrane Nope, but you haven't really removed the e2e-aws job - the generator is not (yet) smart enough to delete jobs that it previously generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants