Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPCT-178: review periodics to add 4.10 and run in opct release #36894

Merged
merged 4 commits into from
Apr 11, 2023
Merged

OPCT-178: review periodics to add 4.10 and run in opct release #36894

merged 4 commits into from
Apr 11, 2023

Conversation

mtulio
Copy link
Contributor

@mtulio mtulio commented Mar 2, 2023 •
edited

https://issues.redhat.com/browse/OPCT-178

The goals of this PR are:

  • decrease the periodic to run all variations once a week only
  • support to run in the binary of thelatest release, not in the main OPCT
  • prepare the periodic to run-upgrade mode, splitting the install and upload from run (run-upgrade will be added separately)
  • support regular executions on OCP 4.10
  • updating owners

Dependencies:

Artifacts produced by rehearsal:

Screenshot from 2023-04-10 16-49-15

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 2, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references OPCT-178 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 2, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 2, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 2, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 2, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references OPCT-178 which is a valid jira issue.

In response to this:

WIP https://issues.redhat.com/browse/OPCT-178

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio mtulio changed the title feat/OPCT-178: run in stable release and improving report WIP | feat/OPCT-178: run in stable release and improving report Mar 2, 2023
@openshift-ci-robot
Copy link
Contributor

@mtulio: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.13-provider-certification-tool-vsphere-upi-platform-external N/A periodic Registry content changed
periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.12-provider-certification-tool-vsphere-upi-platform-none N/A periodic Registry content changed
periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-provider-certification-tool-vsphere-upi-platform-none N/A periodic Registry content changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse refresh to get an updated list of affected jobs (useful if you have new pushes to the branch)

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 2, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Mar 3, 2023

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 3, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references OPCT-178 which is a valid jira issue.

In response to this:

WIP https://issues.redhat.com/browse/OPCT-178

The goals of this PR are:

  • support to run in the binary of thelatest release, not the main
  • prepare the periodic to run-upgrade mode, splitting the install and upload from run
  • support regular executions on OCP 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 3, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references OPCT-178 which is a valid jira issue.

In response to this:

WIP https://issues.redhat.com/browse/OPCT-178

The goals of this PR are:

  • decrease the periodic to run all variations once a week only
  • support to run in the binary of thelatest release, not the main
  • prepare the periodic to run-upgrade mode, splitting the install and upload from run
  • support regular executions on OCP 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mtulio
mtulio commented Mar 3, 2023
View reviewed changes
...or/step-registry/provider-certification-tool/run/provider-certification-tool-run-commands.sh
--metadata '{"platform-type":"'"${CLUSTER_TYPE}"'"}'
# Run the tool in dedicated mode with watch flag set.
echo "Running OPCT with regular mode"
${OPCT_EXEC} run --watch
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowing to log the stdout on CI to extract timing metrics

mtulio
mtulio commented Mar 3, 2023
View reviewed changes
...ertification-tool/redhat-openshift-ecosystem-provider-certification-tool-main-periodics.yaml Outdated
@@ -1,7 +1,89 @@
periodics:
- agent: kubernetes
cluster: vsphere
cron: 0 0 * * 2,4
cron: 0 0 * * 3
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing changed on 4.13, but the order of the jobs were sorted to the newest release first

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 3, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references OPCT-178 which is a valid jira issue.

In response to this:

WIP https://issues.redhat.com/browse/OPCT-178

The goals of this PR are:

  • decrease the periodic to run all variations once a week only
  • support to run in the binary of thelatest release, not in the main of OPCT
  • prepare the periodic to run-upgrade mode, splitting the install and upload from run (run-upgrade will be added separately)
  • support regular executions on OCP 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 3, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references OPCT-178 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/OPCT-178

The goals of this PR are:

  • decrease the periodic to run all variations once a week only
  • support to run in the binary of thelatest release, not in the main OPCT
  • prepare the periodic to run-upgrade mode, splitting the install and upload from run (run-upgrade will be added separately)
  • support regular executions on OCP 4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio mtulio marked this pull request as ready for review March 3, 2023 02:02
@openshift-ci openshift-ci bot requested review from bostrt and dhellmann March 3, 2023 02:03
@mtulio
Copy link
Contributor Author

mtulio commented Mar 3, 2023

@rvanderp3 would you mind taking a look?
/assign @rvanderp3

@mtulio mtulio changed the title WIP | feat/OPCT-178: run in stable release and improving report OPCT-178: run in stable release and improving report Mar 3, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2023
@mtulio mtulio marked this pull request as draft March 3, 2023 02:13
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 3, 2023
@mtulio mtulio changed the title OPCT-178: run in stable release and improving report OPCT-178: review periodics to add 4.10 and run in opct release Mar 3, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Apr 6, 2023

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-provider-certification-tool-vsphere-upi-platform-none

@mtulio
Copy link
Contributor Author

mtulio commented Apr 6, 2023

Now it's working correctly until the run step, suddenly I destroyed the old environment before finish, it was close to finishing the OCP conformance:

Thu, 06 Apr 2023 21:17:40 UTC> Global Status: running
JOB_NAME                           | STATUS     | RESULTS    | PROGRESS                  | MESSAGE                                           
05-openshift-cluster-upgrade       | complete   |            | 0/0 (0 failures)          | waiting for post-processor...                     
10-openshift-kube-conformance      | complete   |            | 352/352 (0 failures)      | waiting for post-processor...                     
20-openshift-conformance-validated | running    |            | 3278/3494 (15 failures)   | status=running=T/C/P/F/S=3494/3278/1222/15/2041   
99-openshift-artifacts-collector   | running    |            | 0/0 (0 failures)          | status=waiting-for=20-openshift-conformance-validated=(0/-216/0)=[1/1080]

Clean up the debug steps, moving the declaration and installation to the install step. Also standardizing the artifact object path considering the OPCT existing and future support:

# Examples:
# OPCT_VERSION/OCP_VERSION-DATE_TS-controlPlaneTopology-provider-platform.tar.gz
# v0.3.0/4.13.0-20230406-HighlyAvailable-vsphere-None.tar.gz
# v0.3.0/4.13.0-20230406-HighlyAvailable-aws-None.tar.gz
# v0.3.0/4.13.0-20230406-HighlyAvailable-aws-AWS.tar.gz
# v0.3.0/4.13.0-20230406-HighlyAvailable-oci-External.tar.gz
# v0.3.0/4.13.0-20230406-HighlyAvailable-oci-Baremetal.tar.gz
# v0.3.0/4.13.0-20230406-SingleReplica-aws-None.tar.gz

Re-running:

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-provider-certification-tool-vsphere-upi-platform-none

@mtulio
Copy link
Contributor Author

mtulio commented Apr 6, 2023

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-provider-certification-tool-vsphere-upi-platform-none

@mtulio
Copy link
Contributor Author

mtulio commented Apr 7, 2023

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-provider-certification-tool-vsphere-upi-platform-none

@mtulio
Copy link
Contributor Author

mtulio commented Apr 8, 2023

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-provider-certification-tool-vsphere-upi-platform-none

@mtulio
Copy link
Contributor Author

mtulio commented Apr 10, 2023

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.13-provider-certification-tool-vsphere-upi-platform-external

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.12-provider-certification-tool-vsphere-upi-platform-none

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-provider-certification-tool-vsphere-upi-platform-none

@mtulio
Copy link
Contributor Author

mtulio commented Apr 10, 2023

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.12-provider-certification-tool-vsphere-upi-platform-none

@mtulio
Copy link
Contributor Author

mtulio commented Apr 10, 2023

Final review:
/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-provider-certification-tool-vsphere-upi-platform-none

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 10, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references OPCT-178 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/OPCT-178

The goals of this PR are:

  • decrease the periodic to run all variations once a week only
  • support to run in the binary of thelatest release, not in the main OPCT
  • prepare the periodic to run-upgrade mode, splitting the install and upload from run (run-upgrade will be added separately)
  • support regular executions on OCP 4.10
  • updating owners

Dependencies:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 10, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references OPCT-178 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/OPCT-178

The goals of this PR are:

  • decrease the periodic to run all variations once a week only
  • support to run in the binary of thelatest release, not in the main OPCT
  • prepare the periodic to run-upgrade mode, splitting the install and upload from run (run-upgrade will be added separately)
  • support regular executions on OCP 4.10
  • updating owners

Dependencies:

Screenshot from 2023-04-10 16-49-15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 10, 2023 •
edited by openshift-ci bot

@mtulio: This pull request references OPCT-178 which is a valid jira issue.

In response to this:

https://issues.redhat.com/browse/OPCT-178

The goals of this PR are:

  • decrease the periodic to run all variations once a week only
  • support to run in the binary of thelatest release, not in the main OPCT
  • prepare the periodic to run-upgrade mode, splitting the install and upload from run (run-upgrade will be added separately)
  • support regular executions on OCP 4.10
  • updating owners

Dependencies:

Artifacts produced by rehearsal:

Screenshot from 2023-04-10 16-49-15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio
Copy link
Contributor Author

mtulio commented Apr 11, 2023

/pj-rehearse periodic-ci-redhat-openshift-ecosystem-provider-certification-tool-main-4.13-provider-certification-tool-vsphere-upi-platform-external

@mtulio
Copy link
Contributor Author

mtulio commented Apr 11, 2023

/rehearsals-ack

@mtulio
Copy link
Contributor Author

mtulio commented Apr 11, 2023

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 11, 2023
@mtulio
Copy link
Contributor Author

mtulio commented Apr 11, 2023

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 11, 2023
@rvanderp3
Copy link
Contributor

nice work @mtulio
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mtulio, rvanderp3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

@mtulio: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit d7ff64c into openshift:master Apr 11, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Apr 11, 2023

@mtulio: Updated the following 2 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key redhat-openshift-ecosystem-provider-certification-tool-main.yaml using file ci-operator/config/redhat-openshift-ecosystem/provider-certification-tool/redhat-openshift-ecosystem-provider-certification-tool-main.yaml
    • key redhat-openshift-ecosystem-provider-certification-tool-main__4.10.yaml using file ci-operator/config/redhat-openshift-ecosystem/provider-certification-tool/redhat-openshift-ecosystem-provider-certification-tool-main__4.10.yaml
    • key redhat-openshift-ecosystem-provider-certification-tool-main__4.12.yaml using file ci-operator/config/redhat-openshift-ecosystem/provider-certification-tool/redhat-openshift-ecosystem-provider-certification-tool-main__4.12.yaml
  • job-config-master-periodics configmap in namespace ci at cluster app.ci using the following files:
    • key redhat-openshift-ecosystem-provider-certification-tool-main-periodics.yaml using file ci-operator/jobs/redhat-openshift-ecosystem/provider-certification-tool/redhat-openshift-ecosystem-provider-certification-tool-main-periodics.yaml

In response to this:

https://issues.redhat.com/browse/OPCT-178

The goals of this PR are:

  • decrease the periodic to run all variations once a week only
  • support to run in the binary of thelatest release, not in the main OPCT
  • prepare the periodic to run-upgrade mode, splitting the install and upload from run (run-upgrade will be added separately)
  • support regular executions on OCP 4.10
  • updating owners

Dependencies:

Artifacts produced by rehearsal:

Screenshot from 2023-04-10 16-49-15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtulio mtulio deleted the opct-178-stable-report branch April 11, 2023 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rvanderp3 rvanderp3

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
4 participants
@mtulio @openshift-ci-robot @rvanderp3 @openshift-merge-robot