Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemeter: enable go modules support #3940

Merged
merged 1 commit into from
Jun 4, 2019
Merged

telemeter: enable go modules support #3940

merged 1 commit into from
Jun 4, 2019

Conversation

paulfantom
Copy link
Contributor

@paulfantom paulfantom commented Jun 3, 2019 •
edited

Use go 1.12 to build telemeter.

Enable go modules support.

/cc @brancz @metalmatze @s-urbaniak @squat

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 3, 2019
@paulfantom paulfantom changed the title telemeter: move to go 1.12 telemeter: enable go modules support Jun 3, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 3, 2019
s-urbaniak
s-urbaniak approved these changes Jun 4, 2019
View reviewed changes
Copy link
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, s-urbaniak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6919106 into openshift:master Jun 4, 2019
@openshift-ci-robot
Copy link
Contributor

@paulfantom: Updated the job-config-master configmap in namespace ci using the following files:

  • key openshift-telemeter-master-presubmits.yaml using file ci-operator/jobs/openshift/telemeter/openshift-telemeter-master-presubmits.yaml

In response to this:

Use go 1.12 to build telemeter.

Enable go modules support.

/cc @brancz @metalmatze @s-urbaniak @squat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulfantom paulfantom deleted the telemeter_go_1.12 branch June 4, 2019 12:59
@paulfantom paulfantom mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s-urbaniak s-urbaniak s-urbaniak approved these changes

@brancz brancz Awaiting requested review from brancz

@metalmatze metalmatze Awaiting requested review from metalmatze

@squat squat Awaiting requested review from squat

Assignees

@s-urbaniak s-urbaniak

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@paulfantom @openshift-ci-robot @s-urbaniak @openshift-merge-robot