Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

telemeter: enable go 1.12 support #3981

Merged
merged 1 commit into from Jun 19, 2019
Merged

telemeter: enable go 1.12 support #3981

merged 1 commit into from Jun 19, 2019

Conversation

paulfantom
Copy link
Contributor

@paulfantom paulfantom commented Jun 6, 2019 •
edited

  • enable go 1.12 in CMO.
  • add job verifying if modules configuration is ok.

Follow-up to #3940
Related to openshift/telemeter#178
Ported from #3942

/cc @brancz @metalmatze @s-urbaniak @squat

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 6, 2019
@paulfantom
Copy link
Contributor Author

/retest

1 similar comment
@paulfantom
Copy link
Contributor Author

/retest

@paulfantom
Copy link
Contributor Author

/test pj-rehearse

@brancz
Copy link
Contributor

brancz commented Jun 19, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brancz, paulfantom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paulfantom
Copy link
Contributor Author

/test ci/prow/core-valid
/test ci/prow/core-dry

@openshift-merge-robot
Copy link
Contributor

/test core-valid
/test core-dry

@openshift-merge-robot openshift-merge-robot merged commit ebd732c into openshift:master Jun 19, 2019
@openshift-ci-robot
Copy link
Contributor

@paulfantom: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci using the following files:
    • key openshift-telemeter-master.yaml using file ci-operator/config/openshift/telemeter/openshift-telemeter-master.yaml
  • ci-operator-master-configs configmap in namespace ci-stg using the following files:
    • key openshift-telemeter-master.yaml using file ci-operator/config/openshift/telemeter/openshift-telemeter-master.yaml
  • job-config-master-presubmits configmap in namespace ci using the following files:
    • key openshift-telemeter-master-presubmits.yaml using file ci-operator/jobs/openshift/telemeter/openshift-telemeter-master-presubmits.yaml

In response to this:

  • enable go 1.12 in CMO.
  • add job verifying if modules configuration is ok.

Follow-up to #3940
Related to openshift/telemeter#178
Ported from #3942

/cc @brancz @metalmatze @s-urbaniak @squat

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulfantom paulfantom deleted the telemeter_go_1.12_vendor branch June 20, 2019 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz Awaiting requested review from brancz

@metalmatze metalmatze Awaiting requested review from metalmatze

@s-urbaniak s-urbaniak Awaiting requested review from s-urbaniak

@squat squat Awaiting requested review from squat

Assignees

@brancz brancz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@paulfantom @brancz @openshift-ci-robot @openshift-merge-robot