Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmd make test-e2e-azident to e2e-azure-manual-oidc #42126

Closed
wants to merge 2 commits into from

Conversation

bentito
Copy link
Contributor

@bentito bentito commented Aug 9, 2023

No description provided.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 9, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bentito
Once this PR has been reviewed and has the lgtm label, please assign abutcher for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@bentito: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc openshift/cloud-credential-operator presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@bentito
Copy link
Contributor Author

bentito commented Aug 10, 2023

@abutcher this matches up with a new make target added in openshift/cloud-credential-operator#587

@bentito
Copy link
Contributor Author

bentito commented Aug 10, 2023

/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc

@bentito
Copy link
Contributor Author

bentito commented Aug 10, 2023

seems like pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc shows it working, in that it tries to call the make target, it's just not on master yet.

@bentito
Copy link
Contributor Author

bentito commented Aug 10, 2023

/pj-rehearse skip

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2023
@openshift-bot
Copy link
Contributor

Issues in openshift/release go stale after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 15d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 9, 2023
@bentito
Copy link
Contributor Author

bentito commented Sep 11, 2023

/pj-rehearse skip

@openshift-bot
Copy link
Contributor

Stale issue in openshift/release rot after 15d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 15d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Sep 26, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 28, 2023

@bentito: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/cloud-credential-operator/master/e2e-azure-manual-oidc b276c5e link unknown /pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc
ci/build-farm/build09-dry b276c5e link true /test build09-dry

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jstuever
Copy link
Contributor

/cc

@openshift-ci openshift-ci bot requested a review from jstuever October 12, 2023 21:39
@@ -130,6 +130,14 @@ tests:
optional: true
steps:
cluster_profile: azure4
test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this override the default tests? We want to ensure we continue running the default tests in addition to the new one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't think this would override anything. It's marked optional and is meant to be called by a periodic, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the latest run, I don't see openshift-tests being executed (yet). Perhaps they would be after the additional tests? I want to ensure they both execute before moving forward with this change.
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/42126/rehearse-42126-pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc/1689504388621537280/artifacts/e2e-azure-manual-oidc/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears this does override the default test. I think we need to add an entry to tests:, preferably above the e2e-test-azident

- ref: openshift-e2e-test

@openshift-bot
Copy link
Contributor

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 28, 2023

@openshift-bot: Closed this PR.

In response to this:

Rotten issues in openshift/release close after 15d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
4 participants