New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cmd make test-e2e-azident to e2e-azure-manual-oidc #42126
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bentito The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
@abutcher this matches up with a new make target added in openshift/cloud-credential-operator#587 |
/pj-rehearse pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc |
seems like |
/pj-rehearse skip |
Issues in openshift/release go stale after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
/pj-rehearse skip |
Stale issue in openshift/release rot after 15d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
@bentito: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/cc |
@@ -130,6 +130,14 @@ tests: | |||
optional: true | |||
steps: | |||
cluster_profile: azure4 | |||
test: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this override the default tests? We want to ensure we continue running the default tests in addition to the new one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wouldn't think this would override anything. It's marked optional and is meant to be called by a periodic, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at the latest run, I don't see openshift-tests being executed (yet). Perhaps they would be after the additional tests? I want to ensure they both execute before moving forward with this change.
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/42126/rehearse-42126-pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc/1689504388621537280/artifacts/e2e-azure-manual-oidc/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears this does override the default test. I think we need to add an entry to tests:
, preferably above the e2e-test-azident
- ref: openshift-e2e-test
Rotten issues in openshift/release close after 15d of inactivity. Reopen the issue by commenting /close |
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.