Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cmd make test-e2e-azident to e2e-azure-manual-oidc #42126

Closed
wants to merge 2 commits into from
Closed

Add cmd make test-e2e-azident to e2e-azure-manual-oidc #42126

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd508cd
Add cmd make test-e2e-azident to e2e-azure-manual-oidc
bentito Aug 9, 2023
b276c5e
After run make ci-operator-config
bentito Aug 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...onfig/openshift/cloud-credential-operator/openshift-cloud-credential-operator-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,14 @@ tests:
optional: true
steps:
cluster_profile: azure4
test:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this override the default tests? We want to ensure we continue running the default tests in addition to the new one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't think this would override anything. It's marked optional and is meant to be called by a periodic, right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the latest run, I don't see openshift-tests being executed (yet). Perhaps they would be after the additional tests? I want to ensure they both execute before moving forward with this change.
https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/42126/rehearse-42126-pull-ci-openshift-cloud-credential-operator-master-e2e-azure-manual-oidc/1689504388621537280/artifacts/e2e-azure-manual-oidc/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears this does override the default test. I think we need to add an entry to tests:, preferably above the e2e-test-azident

- ref: openshift-e2e-test

- as: e2e-test-azident
commands: make test-e2e-azident
from: src
resources:
requests:
cpu: 100m
memory: 200Mi
workflow: openshift-e2e-azure-manual-oidc-workload-identity
- as: e2e-gcp-manual-oidc
optional: true
Expand Down