Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Prow CI workflow Enablement] Use MCE create HostedCluster on BM Disconnected + agent #44946

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

LiangquanLi930
Copy link
Member

@LiangquanLi930 LiangquanLi930 commented Oct 27, 2023

@LiangquanLi930 LiangquanLi930 changed the title add wrokflow: hypershift-mce-agent-disconnected add workflow: hypershift-mce-agent-disconnected Oct 27, 2023
@LiangquanLi930
Copy link
Member Author

OCPQE-16668

@LiangquanLi930
Copy link
Member Author

OCPQE-16671

@LiangquanLi930 LiangquanLi930 force-pushed the mce-agent-dis branch 2 times, most recently from 22da54a to be4d7bb Compare October 27, 2023 15:43
@openshift-ci-robot
Copy link
Contributor

@LiangquanLi930, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

could not load configuration from base revision of release repo: could not checkout worktree: '[git checkout 68b294a1fbd26c2379f43cf292d7f05fa3339d93]' failed with out: fatal: reference is not a tree: 68b294a1fbd26c2379f43cf292d7f05fa3339d93
and error exit status 128
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@LiangquanLi930 LiangquanLi930 force-pushed the mce-agent-dis branch 2 times, most recently from 5830203 to 0284fbd Compare October 28, 2023 04:36
@LiangquanLi930
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-conformance

@LiangquanLi930
Copy link
Member Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-conformance

Copy link
Contributor

@jparrill jparrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropped a question and a small nit, otherwise lgtm

Comment on lines +38 to +39
echo "address=/api.\$HOSTEDCLUSTER_NAME.\$BASEDOMAIN/\$WORKER_IP" >> /etc/NetworkManager/dnsmasq.d/openshift-ostest.conf
echo "address=/api-int.\$HOSTEDCLUSTER_NAME.\$BASEDOMAIN/\$WORKER_IP" >> /etc/NetworkManager/dnsmasq.d/openshift-ostest.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The WORKER_IP comes from the MGMT Cluster's worker or HostedCluster worker? (it should point to the MGMT Nodes where the HCP API is running)

Is this working fine?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep, WORKER_IP comes from the MGMT Cluster's worker

timeout: 30m0s
grace_period: 5m0s
documentation: |-
Deploy nfs( network file system) provisioner for HostedCluster ControlPlane's etcd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit: s/nfs( network file system)/nfs (network file system)/

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2023
@openshift-ci-robot
Copy link
Contributor

@LiangquanLi930, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2023
@jparrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@LiangquanLi930: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-storage-operator-release-4.13-e2e-hypershift-ovn-conformance openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-cluster-csi-snapshot-controller-operator-master-e2e-hypershift-conformance openshift/cluster-csi-snapshot-controller-operator presubmit Registry content changed
pull-ci-openshift-cluster-csi-snapshot-controller-operator-release-4.16-e2e-hypershift-conformance openshift/cluster-csi-snapshot-controller-operator presubmit Registry content changed
pull-ci-openshift-cluster-csi-snapshot-controller-operator-release-4.15-e2e-hypershift-conformance openshift/cluster-csi-snapshot-controller-operator presubmit Registry content changed
pull-ci-openshift-cluster-csi-snapshot-controller-operator-release-4.14-e2e-hypershift-conformance openshift/cluster-csi-snapshot-controller-operator presubmit Registry content changed
pull-ci-openshift-cluster-csi-snapshot-controller-operator-release-4.13-e2e-hypershift-conformance openshift/cluster-csi-snapshot-controller-operator presubmit Registry content changed
pull-ci-openshift-cluster-csi-snapshot-controller-operator-release-4.12-e2e-hypershift-conformance openshift/cluster-csi-snapshot-controller-operator presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.16-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.15-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.13-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.12-e2e-aws-ovn-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.11-e2e-hypershift openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-master-e2e-aws-ovn-kubevirt openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.16-e2e-aws-ovn-kubevirt openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.15-e2e-aws-ovn-kubevirt openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-ovn-kubernetes-release-4.14-e2e-aws-ovn-kubevirt openshift/ovn-kubernetes presubmit Registry content changed
pull-ci-openshift-origin-master-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.15-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-master-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.16-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.15-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-aws-ovn-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-origin-release-4.14-e2e-baremetalds-kubevirt openshift/origin presubmit Registry content changed
pull-ci-openshift-hypershift-main-e2e-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.16-e2e-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.15-e2e-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.14-e2e-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.13-e2e-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-hypershift-release-4.12-e2e-conformance openshift/hypershift presubmit Registry content changed
pull-ci-openshift-apiserver-network-proxy-master-e2e-hypershift openshift/apiserver-network-proxy presubmit Registry content changed
pull-ci-openshift-apiserver-network-proxy-release-4.16-e2e-hypershift openshift/apiserver-network-proxy presubmit Registry content changed
pull-ci-openshift-apiserver-network-proxy-release-4.15-e2e-hypershift openshift/apiserver-network-proxy presubmit Registry content changed

A total of 95 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jparrill
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@@ -6,7 +6,8 @@
"enxebre",
"sjenning",
"imain",
"davidvossel"
"davidvossel",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why all this changes here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added myself here: ci-operator/step-registry/hypershift/OWNERS, Then i run command: make registry-metadata, Which will help me automatically sync up to all these files.

@enxebre
Copy link
Member

enxebre commented Oct 30, 2023

/approve

tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 9, 2024
add e2e-kubevirt-mce-baremetalds-disconnected-conformance
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 15, 2024
add e2e-kubevirt-mce-baremetalds-disconnected-conformance
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 16, 2024
add e2e-kubevirt-mce-baremetalds-disconnected-conformance
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 16, 2024
add e2e-kubevirt-mce-baremetalds-disconnected-conformance
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 17, 2024
add e2e-kubevirt-mce-baremetalds-disconnected-conformance
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 17, 2024
add e2e-kubevirt-mce-baremetalds-disconnected-conformance
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 17, 2024
add e2e-kubevirt-mce-baremetalds-disconnected-conformance
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 17, 2024
add e2e-kubevirt-mce-baremetalds-disconnected-conformance
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 17, 2024
add e2e-kubevirt-mce-baremetalds-disconnected-conformance
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 18, 2024
add e2e-kubevirt-mce-baremetalds-disconnected-conformance
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 18, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 22, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 22, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 22, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 22, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 22, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 22, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 23, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 23, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 23, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 24, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 24, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 24, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 24, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 24, 2024
add e2e-kubevirt-metal-mce-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 26, 2024
add e2e-kubevirt-metal-mce-disconnected and e2e-kubevirt-metal-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 26, 2024
add e2e-kubevirt-metal-mce-disconnected and e2e-kubevirt-metal-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 26, 2024
add e2e-kubevirt-metal-mce-disconnected and e2e-kubevirt-metal-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi added a commit to tiraboschi/release that referenced this pull request Apr 26, 2024
add e2e-kubevirt-metal-mce-disconnected and e2e-kubevirt-metal-disconnected
based on the work for openshift#44946
and openshift#46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
openshift-merge-bot bot pushed a commit that referenced this pull request Apr 29, 2024
…ted (#45407)

* add e2e-kubevirt-metal-mce-disconnected, e2e-kubevirt-metal-disconnected

add e2e-kubevirt-metal-mce-disconnected and e2e-kubevirt-metal-disconnected
based on the work for #44946
and #46584

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

* Add a comment about registry.redhat.io/edo/external-dns-rhel8

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

* Beautify code to be remotely executed on bastion host

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

* Update MCE_INDEX_IMAGE for v4.15

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

* Avoid using scp to pass plaintext variables

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

---------

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
5 participants