-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Prow CI workflow Enablement] Use MCE create HostedCluster on BM Disconnected + agent #44946
Conversation
22da54a
to
be4d7bb
Compare
@LiangquanLi930,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
5830203
to
0284fbd
Compare
/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-conformance |
0284fbd
to
08d94d6
Compare
/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-conformance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dropped a question and a small nit, otherwise lgtm
echo "address=/api.\$HOSTEDCLUSTER_NAME.\$BASEDOMAIN/\$WORKER_IP" >> /etc/NetworkManager/dnsmasq.d/openshift-ostest.conf | ||
echo "address=/api-int.\$HOSTEDCLUSTER_NAME.\$BASEDOMAIN/\$WORKER_IP" >> /etc/NetworkManager/dnsmasq.d/openshift-ostest.conf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The WORKER_IP comes from the MGMT Cluster's worker or HostedCluster worker? (it should point to the MGMT Nodes where the HCP API is running)
Is this working fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, WORKER_IP comes from the MGMT Cluster's worker
timeout: 30m0s | ||
grace_period: 5m0s | ||
documentation: |- | ||
Deploy nfs( network file system) provisioner for HostedCluster ControlPlane's etcd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nit: s/nfs( network file system)/nfs (network file system)/
08d94d6
to
e4e1623
Compare
@LiangquanLi930,
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
e4e1623
to
e772d5a
Compare
/lgtm |
e772d5a
to
fac1ff2
Compare
[REHEARSALNOTIFIER]
A total of 95 jobs have been affected by this change. The above listing is non-exhaustive and limited to 35 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/lgtm |
@@ -6,7 +6,8 @@ | |||
"enxebre", | |||
"sjenning", | |||
"imain", | |||
"davidvossel" | |||
"davidvossel", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why all this changes here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added myself here: ci-operator/step-registry/hypershift/OWNERS
, Then i run command: make registry-metadata
, Which will help me automatically sync up to all these files.
/approve |
add e2e-kubevirt-mce-baremetalds-disconnected-conformance based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-mce-baremetalds-disconnected-conformance based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-mce-baremetalds-disconnected-conformance based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-mce-baremetalds-disconnected-conformance based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-mce-baremetalds-disconnected-conformance based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-mce-baremetalds-disconnected-conformance based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-mce-baremetalds-disconnected-conformance based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-mce-baremetalds-disconnected-conformance based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-mce-baremetalds-disconnected-conformance based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-mce-baremetalds-disconnected-conformance based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected and e2e-kubevirt-metal-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected and e2e-kubevirt-metal-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected and e2e-kubevirt-metal-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
add e2e-kubevirt-metal-mce-disconnected and e2e-kubevirt-metal-disconnected based on the work for openshift#44946 and openshift#46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
…ted (#45407) * add e2e-kubevirt-metal-mce-disconnected, e2e-kubevirt-metal-disconnected add e2e-kubevirt-metal-mce-disconnected and e2e-kubevirt-metal-disconnected based on the work for #44946 and #46584 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> * Add a comment about registry.redhat.io/edo/external-dns-rhel8 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> * Beautify code to be remotely executed on bastion host Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> * Update MCE_INDEX_IMAGE for v4.15 Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> * Avoid using scp to pass plaintext variables Signed-off-by: Simone Tiraboschi <stirabos@redhat.com> --------- Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
This workflow helps us to achieve:
Based on this, I will work on Dual stack + Disconnected.
Job link: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/44946/rehearse-44946-periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-agent-ovn-mce-disconnected-conformance/1718844306439016448