Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add e2e-kubevirt-metal-mce-disconnected, e2e-kubevirt-metal-disconnected #45407

Conversation

tiraboschi
Copy link
Contributor

@tiraboschi tiraboschi commented Nov 7, 2023

add e2e-kubevirt-mce-baremetalds-disconnected-conformance
based on the work for #44946
and #46584

This is currently skipping a few tests:

  • Image policy should update OpenShift object image fields when local names are on
  • Image policy should update standard Kube object image fields when local names are on
  • oc tag should preserve image reference for external images
  • Image policy should perform lookup when the Deployment gets the resolve-names annotation later
  • Image policy should perform lookup when the object has the resolve-names annotation
    that are currently failing on disconnected environments due to https://issues.redhat.com/browse/OCPBUGS-31446

and PersistentVolumes NFS when invoking the Recycle reclaim policy should test that a PV becomes Available and is clean after the PVC is deleted that is failing on disconnected environments due to https://issues.redhat.com/browse/OCPBUGS-31398

The workflow is currently introducing workarounds for:

that should be removed once the related bugs will be fixed.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 7, 2023
@openshift-ci openshift-ci bot requested review from enxebre and imain November 7, 2023 17:38
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-mce-baremetalds-disconnected-conformance

@tiraboschi tiraboschi force-pushed the hypershift_kubevirt_disconnected branch from c386e8f to f4b48de Compare November 8, 2023 15:33
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-mce-baremetalds-disconnected-conformance

@tiraboschi tiraboschi force-pushed the hypershift_kubevirt_disconnected branch from f4b48de to 3df3520 Compare November 8, 2023 17:17
@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Nov 8, 2023
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-mce-baremetalds-disconnected-conformance

@tiraboschi tiraboschi force-pushed the hypershift_kubevirt_disconnected branch 2 times, most recently from 6422538 to 0b187d5 Compare November 8, 2023 20:53
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-mce-baremetalds-disconnected-conformance

@openshift-ci-robot
Copy link
Contributor

@tiraboschi, pj-rehearse: unable to set up jobs ERROR:

failed resolve ReleaseBuildConfiguration: Failed resolve MultiStageTestConfiguration: test/e2e-kubevirt-mce-baremetalds-disconnected-conformance: workflow/hypershift-mce-kubevirt-baremetalds-disconnected-conformance: step/assisted-baremetal-conf-user-data: unresolved parameter: PACKET_PLAN

If the problem persists, please contact Test Platform.

@tiraboschi tiraboschi force-pushed the hypershift_kubevirt_disconnected branch from 0b187d5 to fb23b27 Compare November 8, 2023 21:22
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-mce-baremetalds-disconnected-conformance

1 similar comment
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-mce-baremetalds-disconnected-conformance

@tiraboschi tiraboschi force-pushed the hypershift_kubevirt_disconnected branch from fb23b27 to 884ffaf Compare November 9, 2023 08:52
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-mce-baremetalds-disconnected-conformance

@tiraboschi tiraboschi force-pushed the hypershift_kubevirt_disconnected branch from 884ffaf to 0e9064c Compare November 10, 2023 09:54
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-mce-baremetalds-disconnected-conformance

@tiraboschi tiraboschi force-pushed the hypershift_kubevirt_disconnected branch from 0e9064c to dc159ca Compare November 10, 2023 10:51
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-mce-baremetalds-disconnected-conformance

1 similar comment
@LiangquanLi930
Copy link
Member

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-mce-baremetalds-disconnected-conformance

@tiraboschi tiraboschi force-pushed the hypershift_kubevirt_disconnected branch from dc159ca to 5a55186 Compare November 10, 2023 13:35
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-mce-baremetalds-disconnected-conformance

@tiraboschi tiraboschi force-pushed the hypershift_kubevirt_disconnected branch 2 times, most recently from b647dd1 to e332790 Compare November 10, 2023 16:31
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-mce-baremetalds-disconnected-conformance

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 26, 2024
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 26, 2024
cluster_profile: equinix-ocp-metal
env:
HYPERSHIFT_NODE_COUNT: "2"
MCE_VERSION: "2.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the MCE index image is: brew.registry.redhat.io/rh-osbs/iib:715266, which is just a 2.4 image, even if MCE_VERSION: "2.5" is specified, it still installs version 2.4. If we need to install MCE 2.5, we need to specify the index image for MCE 2.5: brew.registry.redhat.io/rh-osbs/iib:716901

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 29, 2024
@tiraboschi
Copy link
Contributor Author

No code changes
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 29, 2024
scp "${SSHOPTS[@]}" "${CLUSTER_PROFILE_DIR}/pull-secret" "root@${IP}:/home/pull-secret"

# shellcheck disable=SC2087
ssh "${SSHOPTS[@]}" "root@${IP}" bash - << 'EOF'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-file content(REDHAT_OPERATORS_INDEX_TAG,CCS_OPERATOR_CHANNELS, etc), we can accomplish it by passing variables, while for file content(${CLUSTER_PROFILE_DIR}/pull-secret), we can still use SCP.,E.g:

ssh "${SSHOPTS[@]}" "root@${IP}" bash -s -- "$MCE_VERSION" "$MCE_INDEX_IMAGE" << 'EOF' |& sed -e 's/.*auths\{0,1\}".*/*** PULL_SECRET ***/g'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

scp "${SSHOPTS[@]}" "/tmp/mce" "root@${IP}:/home/mce"

# shellcheck disable=SC2087
ssh "${SSHOPTS[@]}" "root@${IP}" bash - << 'EOF'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For non-file content(REDHAT_OPERATORS_INDEX_TAG,CCS_OPERATOR_CHANNELS, etc), we can accomplish it by passing variables, while for file content(${CLUSTER_PROFILE_DIR}/pull-secret), we can still use SCP.,E.g:

ssh "${SSHOPTS[@]}" "root@${IP}" bash -s -- "$MCE_VERSION" "$MCE_INDEX_IMAGE" << 'EOF' |& sed -e 's/.*auths\{0,1\}".*/*** PULL_SECRET ***/g'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@tiraboschi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cloud-provider-kubevirt-main-hypershift-kubevirt-conformance-baremetalds openshift/cloud-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cloud-provider-kubevirt-release-4.17-hypershift-kubevirt-conformance-baremetalds openshift/cloud-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cloud-provider-kubevirt-release-4.16-hypershift-kubevirt-conformance-baremetalds openshift/cloud-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cloud-provider-kubevirt-release-4.15-hypershift-kubevirt-conformance-baremetalds openshift/cloud-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cloud-provider-kubevirt-release-4.14-hypershift-kubevirt-conformance-baremetalds openshift/cloud-provider-kubevirt presubmit Registry content changed
pull-ci-openshift-cluster-storage-operator-release-4.13-e2e-hypershift-ovn-conformance openshift/cluster-storage-operator presubmit Registry content changed
pull-ci-openshift-kubevirt-csi-driver-master-e2e-kubevirt-aws-csi openshift/kubevirt-csi-driver presubmit Registry content changed
pull-ci-openshift-kubevirt-csi-driver-release-4.17-e2e-kubevirt-aws-csi openshift/kubevirt-csi-driver presubmit Registry content changed
pull-ci-openshift-kubevirt-csi-driver-release-4.16-e2e-kubevirt-aws-csi openshift/kubevirt-csi-driver presubmit Registry content changed
pull-ci-openshift-kubevirt-csi-driver-release-4.15-e2e-kubevirt-aws-csi openshift/kubevirt-csi-driver presubmit Registry content changed
pull-ci-openshift-kubevirt-csi-driver-release-4.14-e2e-kubevirt-aws-csi openshift/kubevirt-csi-driver presubmit Registry content changed
pull-ci-openshift-etcd-openshift-4.17-e2e-hypershift-conformance openshift/etcd presubmit Registry content changed
pull-ci-openshift-etcd-openshift-4.16-e2e-hypershift-conformance openshift/etcd presubmit Registry content changed
pull-ci-openshift-etcd-openshift-4.15-e2e-hypershift-conformance openshift/etcd presubmit Registry content changed
pull-ci-openshift-etcd-openshift-4.14-e2e-hypershift-conformance openshift/etcd presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-master-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.17-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.16-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.15-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-image-registry-operator-release-4.14-e2e-hypershift-conformance openshift/cluster-image-registry-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-hypershift-conformance openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.17-e2e-aws-ovn-hypershift-conformance openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.16-e2e-aws-ovn-hypershift-conformance openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.15-e2e-hypershift-ovn openshift/cluster-network-operator presubmit Registry content changed
pull-ci-openshift-cluster-network-operator-release-4.14-e2e-hypershift-ovn openshift/cluster-network-operator presubmit Registry content changed

A total of 160 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 29, 2024
@tiraboschi
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-hypershift-release-4.14-periodics-e2e-kubevirt-metal-mce-disconnected

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@tiraboschi
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@tiraboschi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Apr 29, 2024
@LiangquanLi930
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2024
Copy link
Contributor

openshift-ci bot commented Apr 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidvossel, LiangquanLi930, tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit fcc6277 into openshift:master Apr 29, 2024
20 checks passed
@tiraboschi tiraboschi deleted the hypershift_kubevirt_disconnected branch April 29, 2024 13:50
@tiraboschi tiraboschi restored the hypershift_kubevirt_disconnected branch April 29, 2024 13:50
@tiraboschi tiraboschi deleted the hypershift_kubevirt_disconnected branch April 29, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
6 participants