Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORS-2991: add post-installation check of userTags for image-registry bucket #47844

Merged
merged 1 commit into from Jan 24, 2024
Merged

CORS-2991: add post-installation check of userTags for image-registry bucket #47844

merged 1 commit into from Jan 24, 2024

Conversation

jianli-wei
Copy link
Contributor

@jianli-wei jianli-wei commented Jan 19, 2024 •
edited

  • add step cucushift-installer-check-gcp-user-tags as post-installation check of userTags for image-registry bucket

Note: After https://issues.redhat.com/browse/CORS-2783 is done, the userTags will be also be applied to Compute Instances and Disks. Will add the post-installation check then.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 19, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2024 •
edited by openshift-ci bot

@jianli-wei: This pull request references CORS-2991 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

  • add step cucushift-installer-check-gcp-user-tags as post-installation check of userTags for image-registry bucket

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 19, 2024
@jianli-wei jianli-wei force-pushed the gcp-tags-seperate branch 2 times, most recently from 1eb9ff2 to 7bab6ae Compare January 19, 2024 03:13
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2024 •
edited by openshift-ci bot

@jianli-wei: This pull request references CORS-2991 which is a valid jira issue.

In response to this:

  • add step cucushift-installer-check-gcp-user-tags as post-installation check of userTags for image-registry bucket

Note: After https://issues.redhat.com/browse/CORS-2783 is done, the userTags will be also be applied to Compute Instances and Disks. Will as the post-installation check then.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianli-wei
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.15-installer-rehearse-gcp

@jianli-wei
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.15-installer-rehearse-gcp

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 19, 2024 •
edited by openshift-ci bot

@jianli-wei: This pull request references CORS-2991 which is a valid jira issue.

In response to this:

  • add step cucushift-installer-check-gcp-user-tags as post-installation check of userTags for image-registry bucket

Note: After https://issues.redhat.com/browse/CORS-2783 is done, the userTags will be also be applied to Compute Instances and Disks. Will add the post-installation check then.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jianli-wei
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.15-installer-rehearse-gcp

@jianli-wei
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.15-installer-rehearse-gcp

@jianli-wei
Copy link
Contributor Author

/pj-rehearse periodic-ci-openshift-verification-tests-master-installer-rehearse-4.15-installer-rehearse-gcp

@jianli-wei jianli-wei changed the title WIP: CORS-2991: add post-installation check of userTags for image-registry bucket CORS-2991: add post-installation check of userTags for image-registry bucket Jan 22, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 22, 2024
@jianli-wei
Copy link
Contributor Author

/assign @jianlinliu @gpei please help review, thanks!

@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@jianli-wei: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-amd-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.16-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-arm-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-amd-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.15-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-arm-f14 N/A periodic Registry content changed
periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-amd-f28-destructive N/A periodic Registry content changed
periodic-ci-openshift-verification-tests-master-installer-rehearse-4.15-installer-rehearse-gcp N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-arm-f14 N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jianlinliu
Copy link
Contributor

/lgtm

@jianlinliu
Copy link
Contributor

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jan 24, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianli-wei, jianlinliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

@jianli-wei: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e9034e9 into openshift:master Jan 24, 2024
18 checks passed
@jianli-wei jianli-wei deleted the gcp-tags-seperate branch January 24, 2024 10:59
@jianli-wei jianli-wei mentioned this pull request Jan 30, 2024
Merged
memodi pushed a commit to memodi/release that referenced this pull request Mar 14, 2024
@jianli-wei @memodi
add post-installation check of userTags for image-registry bucket (op…
7c93e4d 
…enshift#47844)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianlinliu jianlinliu jianlinliu left review comments

@gpei gpei Awaiting requested review from gpei

Assignees

@jianlinliu jianlinliu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
3 participants
@jianli-wei @openshift-ci-robot @jianlinliu