New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORS-2991: update user tags values to use double spaces to avoid truncation #48185
Conversation
jianli-wei
commented
Jan 30, 2024
•
edited
edited
- Cont. to CORS-2991: add post-installation check of userTags for image-registry bucket #47844
- Using double spaces in tag value, so as to avoid truncation, as the current logic on truncation sometimes problem
- One failure without the fix: periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-arm-f14
@jianli-wei: This pull request references CORS-2991 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@jianli-wei: This pull request references CORS-2991 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-arm-f14 |
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-arm-f14 |
/lgtm |
/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-4.14-multi-nightly-gcp-ipi-user-labels-tags-filestore-csi-tp-arm-f14 |
.../cucushift/installer/check/gcp/user-tags/cucushift-installer-check-gcp-user-tags-commands.sh
Outdated
Show resolved
Hide resolved
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/lgtm @jianli-wei shall we merge it now after your rehearse testing? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jianli-wei, jianlinliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jianlinliu I'd run one rehearse testing before the last commit, where |
/pj-rehearse ack |