Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-1007: Temporarily remove approved label for coredns-ocp-dnsnameresolver repo #50186

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

arkadeepsen
Copy link
Contributor

This PR removes the approved label temporarily so that openshift/coredns-ocp-dnsnameresolver#1 can be merged. Once that is merged the OWNERS file will get added to the main branch. Then the approved label can be added back for the remaining PRs.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 25, 2024

@arkadeepsen: This pull request references CFE-1007 which is a valid jira issue.

In response to this:

This PR removes the approved label temporarily so that openshift/coredns-ocp-dnsnameresolver#1 can be merged. Once that is merged the OWNERS file will get added to the main branch. Then the approved label can be added back for the remaining PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 25, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2024
@openshift-ci openshift-ci bot requested review from frobware and gcs278 March 25, 2024 13:17
@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 25, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@arkadeepsen: no rehearsable tests are affected by this change

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@alebedev87
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, arkadeepsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

@arkadeepsen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3af0b27 into openshift:master Mar 25, 2024
11 checks passed
Copy link
Contributor

openshift-ci bot commented Mar 25, 2024

@arkadeepsen: Updated the following 2 configmaps:

  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-coredns-ocp-dnsnameresolver-_pluginconfig.yaml using file core-services/prow/02_config/openshift/coredns-ocp-dnsnameresolver/_pluginconfig.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-coredns-ocp-dnsnameresolver-_prowconfig.yaml using file core-services/prow/02_config/openshift/coredns-ocp-dnsnameresolver/_prowconfig.yaml

In response to this:

This PR removes the approved label temporarily so that openshift/coredns-ocp-dnsnameresolver#1 can be merged. Once that is merged the OWNERS file will get added to the main branch. Then the approved label can be added back for the remaining PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

arkadeepsen added a commit to arkadeepsen/release that referenced this pull request Mar 26, 2024
openshift-merge-bot bot pushed a commit that referenced this pull request Mar 26, 2024
…dns-ocp-dnsnameresolver repo (#50186)" (#50223)

This reverts commit 3af0b27.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants