-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CFE-1007: Temporarily remove approved label for coredns-ocp-dnsnameresolver repo #50186
CFE-1007: Temporarily remove approved label for coredns-ocp-dnsnameresolver repo #50186
Conversation
@arkadeepsen: This pull request references CFE-1007 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…dnsnameresolver repo
d3390dd
to
14232c2
Compare
[REHEARSALNOTIFIER] Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alebedev87, arkadeepsen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@arkadeepsen: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@arkadeepsen: Updated the following 2 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…dns-ocp-dnsnameresolver repo (openshift#50186)" This reverts commit 3af0b27.
This PR removes the approved label temporarily so that openshift/coredns-ocp-dnsnameresolver#1 can be merged. Once that is merged the OWNERS file will get added to the main branch. Then the approved label can be added back for the remaining PRs.