Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFE-1007: Revert "Temporarily remove approved label and approve plugin for coredns-ocp-dnsnameresolver repo (#50186)" #50223

Merged

Conversation

arkadeepsen
Copy link
Contributor

This reverts #50186 (commit 3af0b27).

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 26, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 26, 2024

@arkadeepsen: This pull request references CFE-1037 which is a valid jira issue.

In response to this:

This reverts #50186 (commit 3af0b27).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from candita and gcs278 March 26, 2024 07:45
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@arkadeepsen: no rehearsable tests are affected by this change

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Mar 26, 2024
@arkadeepsen arkadeepsen changed the title CFE-1037: Revert "Temporarily remove approved label and approve plugin for coredns-ocp-dnsnameresolver repo (#50186)" CFE-1007: Revert "Temporarily remove approved label and approve plugin for coredns-ocp-dnsnameresolver repo (#50186)" Mar 26, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 26, 2024

@arkadeepsen: This pull request references CFE-1007 which is a valid jira issue.

In response to this:

This reverts #50186 (commit 3af0b27).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2024
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, arkadeepsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

@arkadeepsen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2f6133b into openshift:master Mar 26, 2024
11 checks passed
Copy link
Contributor

openshift-ci bot commented Mar 26, 2024

@arkadeepsen: Updated the following 2 configmaps:

  • plugins configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-coredns-ocp-dnsnameresolver-_pluginconfig.yaml using file core-services/prow/02_config/openshift/coredns-ocp-dnsnameresolver/_pluginconfig.yaml
  • config configmap in namespace ci at cluster app.ci using the following files:
    • key core-services-prow-02_config-openshift-coredns-ocp-dnsnameresolver-_prowconfig.yaml using file core-services/prow/02_config/openshift/coredns-ocp-dnsnameresolver/_prowconfig.yaml

In response to this:

This reverts #50186 (commit 3af0b27).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
3 participants