ci-operator/config/openshift/installer: Bump to golang-1.13 #5928
Conversation
openshift-ci-robot
added
size/XS
|
/hold Gonna wait for the 4.4 fork: openshift/installer#2676 (comment) |
openshift-ci-robot
added
the
do-not-merge/hold
|
Could we exclude 4.3 for the time being and get this into master/4.4 now? @vrutkovs do you prefer to do this pre or post rebase on the focs branch? |
|
@LorbusChris @wking I'd rather have it post-rebase, iirc there's been some changes in module rules though |
|
The errors in fcos/verify-vendor look expected (go mod changing its output) |
|
@wking could you remove the change from the 4.3 branch file, so we can get this in now? Let's also get this into the fcos branch now, we can fix up the builds there later. |
| @@ -7,7 +7,7 @@ build_root: | |||
| image_stream_tag: | |||
| name: release | |||
| namespace: openshift | |||
| tag: golang-1.12 | |||
| tag: golang-1.13 | |||
There was a problem hiding this comment.
let's not do the 4.3, only 4.4 and master
There was a problem hiding this comment.
let's not do the 4.3, only 4.4 and master
Dropped 4.3 with 0af6b8aa0 -> e8ad93b70. Kept FCOS based on this, but I can drop that too if folks want.
wking
force-pushed
the
installer-golang-1.13
branch
from
0af6b8a
to
daeae40
Compare
wking
force-pushed
the
installer-golang-1.13
branch
from
daeae40
to
e8ad93b
Compare
openshift-ci-robot
added
size/S
ci-operator/config/openshift/installer/openshift-installer-fcos.yaml
Outdated
Show resolved
Hide resolved
We need this to bump a Terraform provider [1], which we need to fix an AWS provisioning flake [2]. golang-1.13 became available in CI in 407b8e0 (Add Golang 1.13.1 to CI, 2019-10-01, openshift#5236). Skipping 4.3 [3,4] (which is in code-freeze). [1]: openshift/installer#2676 (comment) [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1759617#c10 [3]: openshift#5928 (comment) [4]: openshift#5928 (comment)
wking
force-pushed
the
installer-golang-1.13
branch
from
e8ad93b
to
562d6fa
Compare
openshift-ci-robot
added
size/XS
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavdahiya, LorbusChris, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
@wking: Updated the following 7 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
We need this to bump a Terraform provider, which we need to fix an AWS provisioning flake. golang-1.13 became available in CI in 407b8e0 (#5236).