ci-operator/templates/openshift/installer/cluster-launch-installer-e2e: Error-catching for Google OAuth pokes #6190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XS
wking
commented
Dec 2, 2019
ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Outdated
Show resolved
Hide resolved
wking
force-pushed
the
gcp-token-poke-debug
branch
from
b141f98
to
4759620
Compare
wking
changed the title
|
I’m not sure what you’re trying to achieve with this change. Describe why you think it’s related? |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
#6190 (comment) is why DNS failures are giving us |
smarterclayton
suggested changes
Dec 3, 2019
ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Outdated
Show resolved
Hide resolved
ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Outdated
Show resolved
Hide resolved
|
/hold cancel But want some changes |
openshift-ci-robot
removed
the
do-not-merge/hold
wking
force-pushed
the
gcp-token-poke-debug
branch
from
4759620
to
3ef3905
Compare
smarterclayton
suggested changes
Dec 3, 2019
ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Outdated
Show resolved
Hide resolved
wking
force-pushed
the
gcp-token-poke-debug
branch
from
3ef3905
to
d612a99
Compare
smarterclayton
suggested changes
Dec 3, 2019
ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
Outdated
Show resolved
Hide resolved
wking
force-pushed
the
gcp-token-poke-debug
branch
from
d612a99
to
2336b88
Compare
…e: Error-catching for Google OAuth pokes Catch non-zero exit codes in the poke that initially landed in 0ec2cd9 (template: Try to poke the GCP auth endpoint in the container, 2019-10-31, openshift#5720) to make it easier to rule out that code when debugging mysterious failures like [1]: Container setup exited with code 6, reason Error --- Lease acquired, installing... Installing from release registry.svc.ci.openshift.org/ci-op-r6dy480t/release@sha256:284ff92845dbfc3ca1be73159acc58b36cbfe03aed05d0f79582ea4207035da9 --- From curl(1), exit 6 is: Couldn't resolve host. The given remote host was not resolved. Clayton suggested including the exit code in the non-zero exit log entry [2]. Testing locally: $ echo $BASH_VERSION 4.2.46(2)-release $ code="$( curl -s -o /dev/null -w "%{http_code}" https://does-not-exist.example.com -X POST -d '' || echo "Failed to POST https://oauth2.googleapis.com/token with $?" 1>&2)" Failed to POST https://oauth2.googleapis.com/token with 6 [1]: https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/openshift_installer/2724/pull-ci-openshift-installer-release-4.3-e2e-gcp/8 [2]: openshift#6190 (comment)
wking
force-pushed
the
gcp-token-poke-debug
branch
from
2336b88
to
8cbef5e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@wking: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Hrm, recent, mysterious exit 6 here. Did I miss something here? |
wking
added a commit
to wking/ci-tools
that referenced
this pull request
Dec 20, 2019
Bringing over a number of changes which have landed in ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml as of openshift/release@016eb4ed27 (Merge pull request openshift/release#6505 from hongkailiu/clusterReaders, 2019-12-19). One series was improved kill logic: * openshift/release@9cd158adf3 (template: Use a more correct kill command, 2019-12-03, openshift/release#6223). * openshift/release@d0744e520d (exit with 0 even if kill failed, 2019-12-09, openshift/release#6295) Another series was around AWS instance console logs: * openshift/release@e102a16d89 (ci-operator/templates/openshift/installer/cluster-launch-installer-e2e: Gather node console logs on AWS, 2019-12-02, openshift/release#6189). * openshift/release@26fde70045 (ci-operator/templates/openshift/installer/cluster-launch-installer-e2e: Set AWS_DEFAULT_REGION, 2019-12-04, openshift/release#6249). And there was also: * openshift/release@cdf97164aa (templates: Add large and xlarge variants, 2019-11-25, openshift/release#6081). * openshift/release@8cbef5e4a7 (ci-operator/templates/openshift/installer/cluster-launch-installer-e2e: Error-catching for Google OAuth pokes, 2019-12-02, openshift/release#6190). * openshift/release@ad29eda8dd (template: Gather the prometheus target metadata during teardown, 2019-12-12, openshift/release#6379).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some echos to the pokes that initially landed in 0ec2cd9 (#5720) to make it easier to rule out that code when debugging mysterious failures like: