Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create machineconfig for m5d #8102

Merged
merged 2 commits into from Apr 3, 2020

Conversation

hongkailiu
Copy link
Member

@hongkailiu hongkailiu commented Apr 2, 2020

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 2, 2020
@alvaroaleman
Copy link
Contributor

@hongkailiu can you just try out if it works by manually applying (and figure out first how to make the resulting nodes tainted so no test workloads end up on it)?

@hongkailiu
Copy link
Member Author

@hongkailiu can you just try out if it works by manually applying (and figure out first how to make the resulting nodes tainted so no test workloads end up on it)?

I will go through the review before i apply to it.
No idea what the effect will be.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 2, 2020
@cgwalters
Copy link
Member

(and figure out first how to make the resulting nodes tainted so no test workloads end up on it)?

If the Ignition config fails, the nodes won't join the cluster at all. (But, I guess it's possible to have the config silently do the wrong thing, so it is worth doing with a machineset of size 1 indeed)

@hongkailiu hongkailiu changed the title [WIP]Create machineconfig for m5d Create machineconfig for m5d Apr 3, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2020
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hongkailiu, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
6 participants