Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the master sidecar #8109

Closed
wants to merge 1 commit into from
Closed

Update the master sidecar #8109

wants to merge 1 commit into from

Conversation

smarterclayton
Copy link
Contributor

No description provided.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2020
@smarterclayton
Copy link
Contributor Author

/retest

1 similar comment
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2020
@abhinavdahiya
Copy link
Contributor

hmm.. usually we see the cvo integration test show up here as pj-rehearse.. but that doens't seem to be happening here..

@ricardomaraschini ricardomaraschini mentioned this pull request Apr 6, 2020
Merged
@dmage
Copy link
Member

dmage commented Apr 7, 2020

@abhinavdahiya because we usually update the sidecar's version and change the job for the master branch to use the new version. This job change is detected by pj-rehearse. The image-registry jobs are also affected by this sidecar.

@smarterclayton did you hold it because of pj-rehearse?

This was referenced Apr 7, 2020
Merged
Merged
@coreydaley
Copy link
Member

/retest

@coreydaley
Copy link
Member

Is there any word on this fix getting merged? There are several openshift/image-registry pull requests waiting on it.

@smarterclayton
Copy link
Contributor Author

This is getting closed in favor of oleg's change #8224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexNPavel AlexNPavel Awaiting requested review from AlexNPavel

@bparees bparees Awaiting requested review from bparees

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
5 participants
@smarterclayton @openshift-ci-robot @abhinavdahiya @dmage @coreydaley