This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Pass an optional hash to RHC::Rest::Commands::Base#rest_client so that the command can demand a minium REST API version #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s the minimum API version.
…rements are met on subsequent calls.
|
Hold up on this until 199 pull request is fixed |
|
Action Required: Pull request cannot be automatically merged |
|
Closing this one, since we decided to put off work on removing the global variable for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifically,
rest_client(:at_least => 1.2)ensures that the REST Client returned is at a minimum version 1.2. If the Client cannot guarantee the desired version,::RHC::APIVersionRequirementNotMetExceptionis thrown.This addresses https://bugzilla.redhat.com/show_bug.cgi?id=867706.