This repository has been archived by the owner on Aug 29, 2018. It is now read-only.
Update domain messages and text to be more domain centric (rather than namespace) #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -535,7 +535,7 @@ def ask_for_namespace | |||
| namespace = nil | |||
| paragraph do | |||
| begin | |||
| namespace = ask "Please enter a namespace (letters and numbers only)#{namespace_optional? ? " |<none>|" : ""}: " do |q| | |||
| namespace = ask "Please enter a domain name (letters and numbers only)#{namespace_optional? ? " |<none>|" : ""}: " do |q| | |||
There was a problem hiding this comment.
This is the only place where I think people might try to enter 'foo.com'
There was a problem hiding this comment.
Changing it back
|
reviewed |
|
reviewed, [merge] |
|
Online Merge Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/4194/) (Image: devenv_3755) |
|
Evaluated for online up to 9620d2c |
|
[Test]ing while waiting on the merge queue |
|
Online Test Results: SUCCESS (https://ci.dev.openshift.redhat.com/jenkins/job/test_pull_requests/4194/) |
|
Origin Test Results: Running (https://originci-openshift.rhcloud.com/job/test_pull_requests/1691/) |
|
Evaluated for origin up to 9620d2c |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@liggitt review