-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1832629: Add metrics for 1xx, 3xx, and 4xx request counters, add latency, track reused connections #128
Bug 1832629: Add metrics for 1xx, 3xx, and 4xx request counters, add latency, track reused connections #128
Conversation
@smarterclayton: This pull request references Bugzilla bug 1832629, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@smarterclayton: This pull request references Bugzilla bug 1832629, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@smarterclayton: This pull request references Bugzilla bug 1832629, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
The router e2e failure is real, will investigate. |
e603038
to
c824010
Compare
/cherry-pick release-4.4 |
@smarterclayton: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
c824010
to
35c6f0b
Compare
/assign @Miciah |
Follow up from preview commit where there were some dangling components.
A number of new metrics have been added to HAProxy that enable better insight into workloads. The 1xx, 3xx, and 4xx counters will allow total request count to be assessed for non passthrough routes. The queue and connect latency metrics will give visibility into moving window latency around overload and TLS termination latencies. The reused connections metric will allow a rough breakdown of which services are experiencing connection churn. The connections total metric is new and is more accurate than sessions, so use that for frontends.
35c6f0b
to
d71cb41
Compare
/retest |
Ready for review. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@smarterclayton: All pull requests linked via external trackers have merged: openshift/router#128. Bugzilla bug 1832629 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@smarterclayton: #128 failed to apply on top of branch "release-4.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
A number of new metrics have been added to HAProxy that enable better insight into workloads.
The 1xx, 3xx, and 4xx counters will allow total request count to be assessed for non passthrough routes.
The queue and connect latency metrics will give visibility into moving window latency around overload and TLS termination latencies.
The reused connections metric will allow a rough breakdown of which services are experiencing connection churn.
The connections total metric is new and is more accurate than sessions, so use that for frontends.
Builds on top of #127
Fixes #81