-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1806648: Fix pod startup reattach/kill loop #110
Bug 1806648: Fix pod startup reattach/kill loop #110
Conversation
We should kill every (non-hostNetwork) sandbox that we can't reattach to OVS, but previously we were only killing "every (non-hostNetwork) sandbox that we knew was previously attached to OVS that we couldn't reattach to OVS".
@abhat: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abhat: This pull request references Bugzilla bug 1792164, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@abhat: This pull request references Bugzilla bug 1792164, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abhat when backporting a patch please link to the original PR as well |
also, 1792164 is the bug for 4.3; you'll need a new clone of it for 4.2 |
@abhat: This pull request references Bugzilla bug 1806648, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Cherry-picked commit from #52 |
/test e2e-aws-upgrade |
2 similar comments
/test e2e-aws-upgrade |
/test e2e-aws-upgrade |
@danwinship can you approve please? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhat, danwinship The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@abhat: All pull requests linked via external trackers have merged. Bugzilla bug 1806648 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We should kill every (non-hostNetwork) sandbox that we can't reattach
to OVS, but previously we were only killing "every (non-hostNetwork)
sandbox that we knew was previously attached to OVS that we couldn't
reattach to OVS".