Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1806648: Fix pod startup reattach/kill loop #110

Merged

Conversation

abhat
Copy link
Contributor

@abhat abhat commented Feb 21, 2020

We should kill every (non-hostNetwork) sandbox that we can't reattach
to OVS, but previously we were only killing "every (non-hostNetwork)
sandbox that we knew was previously attached to OVS that we couldn't
reattach to OVS".

We should kill every (non-hostNetwork) sandbox that we can't reattach
to OVS, but previously we were only killing "every (non-hostNetwork)
sandbox that we knew was previously attached to OVS that we couldn't
reattach to OVS".
@openshift-ci-robot
Copy link
Contributor

@abhat: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Fix pod startup reattach/kill loop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 21, 2020
@abhat abhat changed the title Fix pod startup reattach/kill loop Bug 1792164: Fix pod startup reattach/kill loop Feb 21, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 21, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1792164, which is invalid:

  • expected dependent Bugzilla bug 1765220 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1792164: Fix pod startup reattach/kill loop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor Author

abhat commented Feb 21, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1792164, which is invalid:

  • expected Bugzilla bug 1792164 to depend on a bug in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danwinship
Copy link
Contributor

@abhat when backporting a patch please link to the original PR as well

@danwinship
Copy link
Contributor

also, 1792164 is the bug for 4.3; you'll need a new clone of it for 4.2

@danwinship
Copy link
Contributor

This backports #58 but it needs to include #52 as well.

@abhat abhat changed the title Bug 1792164: Fix pod startup reattach/kill loop Bug 1806648: Fix pod startup reattach/kill loop Feb 24, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Feb 24, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: This pull request references Bugzilla bug 1806648, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1806648: Fix pod startup reattach/kill loop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhat
Copy link
Contributor Author

abhat commented Feb 24, 2020

Cherry-picked commit from #52

@abhat
Copy link
Contributor Author

abhat commented Feb 24, 2020

/test e2e-aws-upgrade

2 similar comments
@abhat
Copy link
Contributor Author

abhat commented Feb 24, 2020

/test e2e-aws-upgrade

@abhat
Copy link
Contributor Author

abhat commented Feb 25, 2020

/test e2e-aws-upgrade

@abhat
Copy link
Contributor Author

abhat commented Feb 25, 2020

@danwinship can you approve please?

@danwinship
Copy link
Contributor

/lgtm
sorry, I actually reviewed this earlier today but I guess I forgot to actually "/lgtm" it...

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhat, danwinship

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2020
@knobunc knobunc added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 26, 2020
@openshift-merge-robot openshift-merge-robot merged commit 7bf1aa8 into openshift:release-4.2 Feb 26, 2020
@openshift-ci-robot
Copy link
Contributor

@abhat: All pull requests linked via external trackers have merged. Bugzilla bug 1806648 has been moved to the MODIFIED state.

In response to this:

Bug 1806648: Fix pod startup reattach/kill loop

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants