Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V0.1.19 update #8

Closed
wants to merge 24 commits into from
Closed

V0.1.19 update #8

wants to merge 24 commits into from

Commits on May 11, 2018

  1. Not all shells set PWD (kubernetes-retired#2024)

    CURDIR is guaranteed to be there by Make.
    wryun authored and Doug Davis committed May 11, 2018
    Configuration menu
    Copy the full SHA
    70e3b2a View commit details
    Browse the repository at this point in the history

Commits on May 14, 2018

  1. Ensure ServiceBinding gets deleted when ServiceInstance updated to an…

    … invalid plan after a successful bind (kubernetes-retired#1922)
    
    The reconcileServiceBindingDelete() method, before it sent the unbind
    request to the broker, tried to retrieve the ClusterServicePlan referenced
    in the ServiceInstance that the ServiceBinding points to. If that plan
    did not exist (such as in cases when the user changed the plan on the
    instance), the binding could not be deleted. The controller must be able
    to perform an unbind even if the plan doesn't exist, so it shouldn't
    retrieve the plan at all.
    
    This commit changes the controller so it no longer retrieves the plan.
    Additionally, the controller now gets the plan ID from Instance.Status.
    ExternalProperties, which holds the correct plan id needed for unbind
    (whereas the plan in Instance.Spec.ClusterServicePlanRef may be no
    longer match the plan ID used when the bind request was performed).
    luksa authored and Jay Boyd committed May 14, 2018
    Configuration menu
    Copy the full SHA
    ded16de View commit details
    Browse the repository at this point in the history
  2. Add --wait flag to svcat commands (kubernetes-retired#1991)

    * Allow waiting for provision to complete
    
    svcat provision --wait does not return until the instance is ready or
    failed.
    
    * Allow waiting for bind to complete
    
    svcat bind --wait does not return until the binding is ready or
    failed.
    
    * Use IsBindingReady helper function
    
    * Allow waiting for unbind to complete
    
    * Allow waiting for deprovision to complete
    
    * Add verbose logging
    
    * Update help text with --wait and --timeout
    
    * Tweak log message
    
    * Move wait logic into command interface
    
    * Add --interval flag
    
    * Add missing boilerplate
    
    * Improve error handling for displaying final result after polling
    
    * Make golint happy
    carolynvs committed May 14, 2018
    Configuration menu
    Copy the full SHA
    88130de View commit details
    Browse the repository at this point in the history
  3. Set ExternalID in strategy, not defaults (kubernetes-retired#2028)

    This allows admission controller to detect whether the user has set the
    UUID or not. See kubernetes-retired#1928
    wryun authored and carolynvs committed May 14, 2018
    Configuration menu
    Copy the full SHA
    6c3b534 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2018

  1. don't list plans twice (svcat describe class --traverse) (kubernetes-…

    …retired#2026)
    
    * don't list plans twice, don't include include the plan unless --traverse
    
    * fix unit test
    
    * remove traverse option, include plans when doing describe class
    Jay Boyd authored and jpeeler committed May 15, 2018
    Configuration menu
    Copy the full SHA
    cd1c2fd View commit details
    Browse the repository at this point in the history

Commits on May 16, 2018

  1. Improve svcat's "x is required" error messages & make them consistent (

    …kubernetes-retired#2038)
    
    * Improve svcat's "x is required" error messages & make them consistent
    
    * Add missing test "bind requires arg" & make error message consistent
    luksa authored and Jay Boyd committed May 16, 2018
    Configuration menu
    Copy the full SHA
    9678178 View commit details
    Browse the repository at this point in the history
  2. Add ServiceBroker control loop (kubernetes-retired#1993)

    Adds the following:
    
    * Extends controller to support namespaced types
    * ServiceBroker control loop
    * Initial unit test support
    Erik Nelson authored and pmorie committed May 16, 2018
    Configuration menu
    Copy the full SHA
    6a693a7 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2018

  1. allow nill service plan during instance last op poll (kubernetes-reti…

    …red#1940) (kubernetes-retired#1941)
    
    * allow nill service plan during instance last op poll (kubernetes-retired#1940)
    
    * get plan from InProgressProperties when deprovision
    
    * fail with error if InProgressProperties is nil
    Jay Boyd authored and pmorie committed May 17, 2018
    Configuration menu
    Copy the full SHA
    491f227 View commit details
    Browse the repository at this point in the history
  2. Improve devguide for first time contributors (kubernetes-retired#2041)

    * Explain golden files in the devguide
    
    * Explain that golden files need to be validated and diffed before committing
    
    * Add checklist for new contributors
    
    * More clarifications
    
    * Add making a contribution to the toc
    
    * Clarify that -update doesn't create/delete files
    
    * Link to golden file doc in failed test output
    
    * Incorporate PR feedback
    
    * Turn into hyperlink
    
    * Link to doc in the toc
    carolynvs authored and jpeeler committed May 17, 2018
    Configuration menu
    Copy the full SHA
    741f98f View commit details
    Browse the repository at this point in the history
  3. Vendor build tools (kubernetes-retired#2034)

    * vendor golint
    
    * use vendored golint in build image
    
    * install az cli from a binary instead of python
    carolynvs authored and jpeeler committed May 17, 2018
    Configuration menu
    Copy the full SHA
    2e42663 View commit details
    Browse the repository at this point in the history
  4. svcat: Show ParametersFrom in describe commands (kubernetes-retired#2043

    )
    
    * svcat: Show ParametersFrom in describe commands
    
    * Check if ParametersFrom.SecretKeyRef is nil
    
    * Simplify formatting of Parameters From
    luksa authored and carolynvs committed May 17, 2018
    Configuration menu
    Copy the full SHA
    64fef18 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2018

  1. v0.1.19 Release (kubernetes-retired#2048)

    - update chart references
    carolynvs committed May 18, 2018
    Configuration menu
    Copy the full SHA
    30be2f4 View commit details
    Browse the repository at this point in the history
  2. tooling: move service-catalog Makefile as non-default

    jpeeler authored and Jay Boyd committed May 18, 2018
    Configuration menu
    Copy the full SHA
    d3b1ac9 View commit details
    Browse the repository at this point in the history
  3. tooling: add build tools populated by release script

    Specifically, in the openshift/release repo using tools/hack/golang/update <path to catalog git checkout> service-catalog
    
    Only modifications made from the vanilla configuration was OS_GO_PACKAGE
    and OS_CROSS_COMPILE_TARGETS in hack/lib/constants.sh.
    jpeeler authored and Jay Boyd committed May 18, 2018
    Configuration menu
    Copy the full SHA
    20289a0 View commit details
    Browse the repository at this point in the history
  4. tooling: modify spec for service-catalog

    TODO items removed/changed.
    jpeeler authored and Jay Boyd committed May 18, 2018
    Configuration menu
    Copy the full SHA
    f28e3a7 View commit details
    Browse the repository at this point in the history
  5. tooling: add image buildling files

    jpeeler authored and Jay Boyd committed May 18, 2018
    Configuration menu
    Copy the full SHA
    a5425e1 View commit details
    Browse the repository at this point in the history
  6. tooling: make RPM building work

    jpeeler authored and Jay Boyd committed May 18, 2018
    Configuration menu
    Copy the full SHA
    4b0065f View commit details
    Browse the repository at this point in the history
  7. tooling: add image building files for origin-source

    jpeeler authored and Jay Boyd committed May 18, 2018
    Configuration menu
    Copy the full SHA
    297a261 View commit details
    Browse the repository at this point in the history
  8. tooling: add svcat to build and create another RPM

    jpeeler authored and Jay Boyd committed May 18, 2018
    Configuration menu
    Copy the full SHA
    9f22696 View commit details
    Browse the repository at this point in the history
  9. tooling: update golang to 1.9

    jpeeler authored and Jay Boyd committed May 18, 2018
    Configuration menu
    Copy the full SHA
    ad6de4e View commit details
    Browse the repository at this point in the history
  10. tooling: add version information to catalog binary

    jpeeler authored and Jay Boyd committed May 18, 2018
    Configuration menu
    Copy the full SHA
    6d2a4ea View commit details
    Browse the repository at this point in the history
  11. tooling: bump epoch to 1

    Since previously service-catalog code was inside the origin repo, the
    versioning was inherited there too. Now that a separate repo exists that
    is largely unmodified code from upstream, upstream versioning is used.
    The epoch is bumped to ensure upgrades work properly since origin
    versioning is way larger than any catalog release to date.
    jpeeler authored and Jay Boyd committed May 18, 2018
    Configuration menu
    Copy the full SHA
    6829167 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    02cbdb0 View commit details
    Browse the repository at this point in the history
  13. Merge branch 'master' into v0.1.19-update

    Jay Boyd committed May 18, 2018
    Configuration menu
    Copy the full SHA
    8966629 View commit details
    Browse the repository at this point in the history