V0.1.19 update #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CURDIR is guaranteed to be there by Make.
… invalid plan after a successful bind (kubernetes-retired#1922) The reconcileServiceBindingDelete() method, before it sent the unbind request to the broker, tried to retrieve the ClusterServicePlan referenced in the ServiceInstance that the ServiceBinding points to. If that plan did not exist (such as in cases when the user changed the plan on the instance), the binding could not be deleted. The controller must be able to perform an unbind even if the plan doesn't exist, so it shouldn't retrieve the plan at all. This commit changes the controller so it no longer retrieves the plan. Additionally, the controller now gets the plan ID from Instance.Status. ExternalProperties, which holds the correct plan id needed for unbind (whereas the plan in Instance.Spec.ClusterServicePlanRef may be no longer match the plan ID used when the bind request was performed).
* Allow waiting for provision to complete svcat provision --wait does not return until the instance is ready or failed. * Allow waiting for bind to complete svcat bind --wait does not return until the binding is ready or failed. * Use IsBindingReady helper function * Allow waiting for unbind to complete * Allow waiting for deprovision to complete * Add verbose logging * Update help text with --wait and --timeout * Tweak log message * Move wait logic into command interface * Add --interval flag * Add missing boilerplate * Improve error handling for displaying final result after polling * Make golint happy
This allows admission controller to detect whether the user has set the UUID or not. See kubernetes-retired#1928
…retired#2026) * don't list plans twice, don't include include the plan unless --traverse * fix unit test * remove traverse option, include plans when doing describe class
…kubernetes-retired#2038) * Improve svcat's "x is required" error messages & make them consistent * Add missing test "bind requires arg" & make error message consistent
Adds the following: * Extends controller to support namespaced types * ServiceBroker control loop * Initial unit test support
…red#1940) (kubernetes-retired#1941) * allow nill service plan during instance last op poll (kubernetes-retired#1940) * get plan from InProgressProperties when deprovision * fail with error if InProgressProperties is nil
* Explain golden files in the devguide * Explain that golden files need to be validated and diffed before committing * Add checklist for new contributors * More clarifications * Add making a contribution to the toc * Clarify that -update doesn't create/delete files * Link to golden file doc in failed test output * Incorporate PR feedback * Turn into hyperlink * Link to doc in the toc
* vendor golint * use vendored golint in build image * install az cli from a binary instead of python
- update chart references
Specifically, in the openshift/release repo using tools/hack/golang/update <path to catalog git checkout> service-catalog Only modifications made from the vanilla configuration was OS_GO_PACKAGE and OS_CROSS_COMPILE_TARGETS in hack/lib/constants.sh.
TODO items removed/changed.
Since previously service-catalog code was inside the origin repo, the versioning was inherited there too. Now that a separate repo exists that is largely unmodified code from upstream, upstream versioning is used. The epoch is bumped to ensure upgrades work properly since origin versioning is way larger than any catalog release to date.
openshift-bot
added
the
needs-rebase
openshift-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jboyd01 Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-bot
removed
the
needs-rebase
openshift-bot
added
the
needs-rebase
openshift-bot
removed
the
needs-rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.