New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: use go 1.12 and migrate to go modules #178
Conversation
/hold |
/hold cancel |
small nit: can you split the vendor commit? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: paulfantom, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Additionally during migration I discovered an incorrect invocation ofuuid.Must
function, which is also fixed in this PR.Additionally bumped golangci-lint binary as previous one wasn't aware of go modules.
/cc: @brancz @metalmatze @s-urbaniak @squat