test/e2e: fix forward test #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The e2e tests were never being run as part of the CI workflow. Also, because the e2e test files were excluded from the list of packages, they were not statically checked. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
All metrics received by the v1 ingester and forwarded will have their timestamps overwritten by the validator, so it doesn't make sense to ensure that the timestamp is unchanged. Signed-off-by: Lucas Servén Marín <lserven@gmail.com>
openshift-ci-robot
added
the
size/S
openshift-ci-robot
added
the
approved
|
/test e2e-aws-upgrade |
|
/lgtm |
bwplotka
approved these changes
Dec 6, 2019
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, bwplotka, metalmatze, squat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The e2e tests were never being run as part of the CI workflow. Also,
because the e2e test files were excluded from the list of packages, they
were not statically checked.
All metrics received by the v1 ingester and forwarded will have their
timestamps overwritten by the validator, so it doesn't make sense to
ensure that the timestamp is unchanged.
Signed-off-by: Lucas Servén Marín lserven@gmail.com
cc @kakkoyun @metalmatze