Merge changes from v2.4.0-rc.1

[bertinatto]

• Bring in changes from v2.4.0-rc.1 tag
• Restore OpenShift-related configuration
• Add vendor directory

CC @openshift/storage

[bertinatto]

/hold
For manual testing these changes.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [bertinatto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bertinatto]

/retest

[bertinatto]

/test e2e-vsphere

[jsafrane]

For the record: diff to upstream tag: kubernetes-sigs/vsphere-csi-driver@v2.4.0-rc.1...bertinatto:rebase-v2.4.0-rc.1

I see quite lot of changes in the driver code, is that expected?

[bertinatto]

For the record: diff to upstream tag: kubernetes-sigs/vsphere-csi-driver@v2.4.0-rc.1...bertinatto:rebase-v2.4.0-rc.1

I see quite lot of changes in the driver code, is that expected?

Your link above is comparing the changes made in rebase-v2.4.0-rc.1 since the most recent commit that's shared between these 2 refs (which is 4981393 [git merge-base v2.4.0-rc.1 rebase-v2.4.0-rc.1] from Feb, by the way).

Since our fork contains duplicate commits, a better way would be to compare the code differences between the last snapshots from both refs (with 2 or no dots):

https://github.com/kubernetes-sigs/vsphere-csi-driver/compare/v2.4.0-rc.1..bertinatto:rebase-v2.4.0-rc.1

Or:

$ git diff v2.4.0-rc.1..rebase-v2.4.0-rc.1 --stat
.ci-operator.yaml                                  |      4 +
.gitignore                                         |      6 -
Dockerfile.openshift                               |     14 +
Dockerfile.syncer.openshift                        |     20 +
Makefile                                           |     15 +-
OWNERS                                             |     25 +-
OWNERS_ALIASES                                     |      7 +
go.sum                                             |      2 -
vendor/github.com/Azure/go-ansiterm/LICENSE        |     21 +
vendor/(...)
5995 files changed, 2102938 insertions(+), 37 deletions(-)

[gnufied]

This looks good to me. The commits are same as last diff - kubernetes-sigs/vsphere-csi-driver@v2.3.0-rc.3...bertinatto:rebase-v2.3.0-rc.3

[gnufied]

/lgtm

[jsafrane]

You're right, the changes look OK

[bertinatto]

/hold cancel