Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STOR-863: Rebase to v2.6.0 #44

Merged
merged 184 commits into from
Sep 23, 2022
Merged

STOR-863: Rebase to v2.6.0 #44

merged 184 commits into from
Sep 23, 2022

Conversation

RomanBednar
Copy link

@RomanBednar RomanBednar commented Sep 12, 2022 •
edited
Loading

Diff to upstream v2.6.0:
kubernetes-sigs/vsphere-csi-driver@v2.6.0...RomanBednar:rebase-v2.6.0

Notable changes since v2.5.1:

  • Enhanced Volume Topology
  • Support migration of in-tree vSphere PVs with legacy topology labels
  • Support RWX PV provisioning on remote vSAN
  • Support running vSphere Container Storage Plug-in on a different Kubernetes cluster

Changelog:
https://github.com/kubernetes-sigs/vsphere-csi-driver/releases/tag/v2.6.0

@openshift/storage

shalini-b and others added 30 commits February 1, 2022 16:42
@shalini-b
TKGS-HA Supervisor CreateVolume workflow (kubernetes-sigs#1503)
2b1283f
@Aishwarya-Hebbar
Combine last 12 commits into one (kubernetes-sigs#1490)
049ec17 
polling-changes

polling-changes

polling-changes

polling-changes

polling-changes

polling-changes

polling-changes

polling-changes

polling-changes

polling-changes

polling-changes

polling-changes
@rpanduranga
[e2e-test]: Add test for PVC claiming the available resource parallely (
065eaf7 
kubernetes-sigs#1456)

Adding an automation test for the PVCs claiming the available resource parallely
@sashrith
fixes for fetching node VM uuid from csinode instead of k8s node when…
56b0c8d 
… use-csinode-id FSS is enabled (kubernetes-sigs#1487)
@divyenpatel
fix volume expand issue with improved-Idempotency feature and add vSp…
45bde63 
…here 8.0 support (kubernetes-sigs#1519)
Update the error type check of NotFound (kubernetes-sigs#1518)
adca3f4
Avoid setting provisioner annotation (kubernetes-sigs#1528)
2c96ab7 
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
@divyenpatel
support storage-provisioner GA annotation for k8s 1.23 (kubernetes-si…
8dbe867 
…gs#1535)
@shalini-b
Bump up sidecar containers (kubernetes-sigs#1527)
ad77af1
@smanjunath3
Add the FSS for ListVolume API (kubernetes-sigs#1496)
edbe68f
@Aishwarya-Hebbar
Added tests for vsan-stretched cluster testing for vanilla block (kub…
7697425 
…ernetes-sigs#1494)
@pradeep-hegde
Fix image tag and image label commit ID for release branches (kuberne…
c12b9c9 
…tes-sigs#1542)

Added tests for vsan-stretched cluster testing for vanilla block (kubernetes-sigs#1494)
Prevent filevolume creation on a stretched cluster setup (kubernetes-…
29d35a4 
…sigs#1545)

Signed-off-by: Deepak Kinni <dkinni@vmware.com>
Fixed the VC login failure in CSI during WCP password rotation (kuber…
ebc8ded 
…netes-sigs#1534)
Update restrictions on filevolume creation in a tkgs ha setup (kubern…
21859e3 
…etes-sigs#1546)

Signed-off-by: Deepak Kinni <dkinni@vmware.com>
@sipriyaa
Automation test-cases for Topology Table2 (kubernetes-sigs#1524)
9966c56 
* Automation testcases for Topology Table2

* AfterEach block added to the code
Improve csi snapshot deployment script (kubernetes-sigs#1551)
eee566c 
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
@xinyanw409
pv to vvol mapping (kubernetes-sigs#1516)
fcd6dae
Fix in DeleteSnapshot to handle ManagedObjectNotFound error properly (k…
5572f1f 
…ubernetes-sigs#1554)
Specify QPS and Burst for csi-snapshotter (kubernetes-sigs#1561)
228313f 
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
@sashrith
remove dependency on driver packages from e2e tests - part1 (kubernet…
76c44c7 
…es-sigs#1517)
@sashrith
return false if FSS is not found instead of failing in isCsiFssEnable…
ab4d73e 
…d() (kubernetes-sigs#1550)
@divyenpatel
change PVC annotation keys for TKGS HA (kubernetes-sigs#1568)
bb489b3
@gohilankit
Add arg to disable gocsi in SV and pvcsi yamls (kubernetes-sigs#1529)
1616edd
@xinyanw409
Fix linter error introduced from PR 1516 (kubernetes-sigs#1569)
6a79a1e
@rpanduranga
Block Volume Snapshot Test (kubernetes-sigs#1543)
ffc7acc
@divyenpatel
bump up CSI provisioner for TKGS HA (kubernetes-sigs#1580)
aba06ba
@smanjunath3
Vsphere conf changes for ListVolume API change (kubernetes-sigs#1510)
ec56f06
CSI snapshot deployment script improvements (kubernetes-sigs#1583)
a5c07b6 
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
Always report snapshot capabilities (kubernetes-sigs#1585)
8e88f80 
Signed-off-by: Deepak Kinni <dkinni@vmware.com>
@RomanBednar
Copy link
Author

kubernetes-sigs/vsphere-csi-driver@v2.6.0...RomanBednar:rebase-v2.6.0

Why are there changes in pkg/csi/service/common/common_controller_helper.go and pkg/csi/service/vanilla/controller.go? Even compiler does not like them.

Merge strategy caused duplicates and I missed that. Trying different approach.

@RomanBednar
Copy link
Author

/retest

@RomanBednar
Copy link
Author

/retest

@RomanBednar
Copy link
Author

/test e2e-vsphere-csi-migration

@jsafrane
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 15, 2022
@RomanBednar
Copy link
Author

/retest

1 similar comment
@RomanBednar
Copy link
Author

/retest

@jsafrane
Copy link

@RomanBednar I missed invalid OWNERS error, please clean that up (delete or update offending OWNERS in the first <carry> patch.

@openshift-ci openshift-ci bot removed lgtm Indicates that a PR is ready to be merged. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Sep 19, 2022
@RomanBednar
Copy link
Author

@RomanBednar I missed invalid OWNERS error, please clean that up (delete or update offending OWNERS in the first <carry> patch.

@jsafrane ack, removing e2e tests OWNERS file

@jsafrane
Copy link

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 19, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 19, 2022

@RomanBednar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-csi-migration b9959ca link false /test e2e-vsphere-csi-migration

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@duanwei33
Copy link

Pre-merge verified passed with regression test, no issue found.
For the new Volume Topology feature, will test it in 4.12 new feature.

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 19, 2022
@jsafrane
Copy link

/label docs-approved
/label px-approved

We don't document / announce CSI driver version bumps to customers.

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Sep 23, 2022
@openshift-merge-robot openshift-merge-robot merged commit 18e64c5 into openshift:master Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto Awaiting requested review from bertinatto

@tsmetana tsmetana Awaiting requested review from tsmetana

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.