Downstream sync: July '21 #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Server address in whereabouts.kubeconfig file has wrong format when the service has IPv6 address. The IPv6 server address must be wrapped in '[]'.
This changes change error message in case of kubeconfig non-existence at loading IPAM config to cause appropreate error message when kubeconfig is not exist in case of kubernetes CRD mode.
Change error message
This fix supplies domain for container image repo because in some runtime configuration, 'docker.io' is not specified as default container repository url.
Specifiy image repo URL explicitly
Fixing wrong DNS-1123 name for some IPv6 addresses
Add a more meaningful error for invalid CIDR
whereabouts.kubeconfig wrong in IPv6 only env
Adds the missing error/log/warn methods to the install-cni.sh
…tors README for auto config, also preps readme for deprecating etcd
Excluded subnets was handled for ipv4. This fix handles ipv6 as well. Fixes dougbtv/whereabouts#71 Adds test to check for excluding IPv6 addresses
Includes fix for excluding IPv6 ranges as well as unit test
Removes error when deallocating IP errors out, instead just warns.
Reduces required parameters by introducing flatfile configuration by default
This removes the logic that was IPv4 based for removing the broadcast address. [IPv6 does not implement broadcast](https://en.wikipedia.org/wiki/IPv6_address#Addressing_methods). It also adds a unit test to validate that, as well as updates some checks which wrongly assumed the broadcast address omission.
Logic for IPv6 assignment should not omit the broadcast addresses
This removes the (now default) kubernetes data store from the first CNI config example.
The first example can drop the optional parameters
updated readme with instructions on how to install using helm3
It only requires two. Also updated the paragraph there for better context, added IPv6 subnet calculator link.
README incorrectly stated Whereabouts requires three parameters
[travis] Adds a login so we can pull images from the registry
This change replaces travis CI with github actions.
This behavior will be encapsulated in a new struct named
`ReconcileLooper`, which features methods for:
- CancelContext; cancels the current execution context
- FindOrphanedIPsPerPool; returns a list of the orphaned
IP addresses, indexed by pool
- ReconcileIPPool; receives a list of orphaned IP
addresses, and cleans them up from the respective pools
where they are currently allocated.
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
The service account for whereabouts requires the ability of listing the pods on all namespaces, so it can check which ones feature orphaned IPs. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Only mark a pod as "alive" when the pod's annotations feature the IP being de-allocated. This makes the reconciler binary *dependent* on multus, which adds these `network-status` annotations into the pod. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
By not returning an `IPReservation` entry - we now return an IP address instead - we simplify the code. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
This commit changes the reconciler logic to only parse the network-status annotations of whereabouts pods - e.g. pods whose pod referecences (<namespace>/<pod name>) feature in any of the whereabouts IPPools. Signed-off-by: Miguel Duarte Barroso <mdbarroso@redhat.com>
IP ranges cleanup
Fixes conflicts after cherry-picking and lifting the overlapping ip addresses feature.
openshift-ci
bot
added
the
approved
|
/hold Needs:
|
openshift-ci
bot
added
the
do-not-merge/hold
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
dougbtv
force-pushed
the
downstream-sync-july21
branch
from
0fd4a10
to
40689a7
Compare
…penshift and adds copy for the ip-reconciler
dougbtv
force-pushed
the
downstream-sync-july21
branch
from
40689a7
to
9c65b3b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, maiqueb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notable features:
Big ups to @maiqueb for a ton of work this release. And thanks to Tomo for the leader election feature.