Skip to content
This repository has been archived by the owner on Jul 23, 2020. It is now read-only.

vert.x dnsresolver does not work in che #3428

Closed
maxandersen opened this issue May 3, 2018 · 10 comments
Closed

vert.x dnsresolver does not work in che #3428

maxandersen opened this issue May 3, 2018 · 10 comments

Comments

@maxandersen
Copy link
Collaborator

maxandersen commented May 3, 2018

if you run vert.x without use of fmp on openshift - need to set Dvertx.disableDnsResolver=true to make it work on che or in any other IDE using pods.

possible fixes:
change https://github.com/redhat-developer/rh-che/blob/master/assembly/fabric8-stacks/src/main/resources/stacks.json#L476 to have this flag set

OR

change booster pom's to have it set for vertx:run

OR

change the booster to have a main to set the flag early

@maxandersen
Copy link
Collaborator Author

/cc @qodfathr and @slemeur - for you awareness; i put p0 on it since without it you can actually use http api's from outside the openshift cluster when doing vert.x apps. Let me know if agree/disagree.

@ibuziuk
Copy link
Collaborator

ibuziuk commented May 3, 2018

seems relevant to add this flag to command if it does not have side effects.
Or is it planned to have a fix from quickstart side ? there is already one update pending for quickstart - #2988 (comment)

@maxandersen
Copy link
Collaborator Author

@cescoffier what do you guys prefer ? seems fixing it in the pom.xml would be the best/most complete option ?

but if not then lets fix it in the stacks. And yes @ibuziuk it does not have any sideeffects as far as we know except actually making it work reliably ;)

@ibuziuk
Copy link
Collaborator

ibuziuk commented May 3, 2018

@cescoffier we are going to make rollout (hopefully last before summit) on prod tomorrow, so please let me know if we should update the command

@cescoffier
Copy link

I would recommend disabling the async DNS resolver in Che. So yes updating the command would work and is probably the best approach.

@ibuziuk
Copy link
Collaborator

ibuziuk commented May 4, 2018

@cescoffier ok, lemme provide PR with command update.
Could you please tell if any more quickstart updates are planned before summit ? each update could potentiallyintroduce subtle bugs and might require rebuilding our stacks. So, please give me a heads-up about this

@ibuziuk
Copy link
Collaborator

ibuziuk commented May 4, 2018

PR is sent redhat-developer/rh-che#662

@ibuziuk
Copy link
Collaborator

ibuziuk commented May 4, 2018

PR for rh-che is merged - should be soon on prod-preview
Also send a PR to upstream - eclipse-che/che#9611

@ibuziuk ibuziuk self-assigned this May 4, 2018
@ibuziuk
Copy link
Collaborator

ibuziuk commented May 4, 2018

@maxandersen @cescoffier @slemeur fix is available on prod:

image

are you ok to close ?

@cescoffier
Copy link

Ok for me

@slemeur slemeur closed this as completed May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants