Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added SpatialVec Output and Reporter access to Swig interface #2030

Merged
merged 2 commits into from
Jan 20, 2018
Merged

Added SpatialVec Output and Reporter access to Swig interface #2030

merged 2 commits into from
Jan 20, 2018

Conversation

jimmyDunne
Copy link
Member

Fixes issue #<issue_number>
#2029

Brief summary of changes

Added SpatialVec access for outputs and reporters

Testing I've completed

Run local tests and confirmed that access is available

@chrisdembia
Copy link
Member

Neat. This is good to have. The Travis builds failed.

aymanhab
aymanhab approved these changes Nov 30, 2017
View reviewed changes
Copy link
Member

@aymanhab aymanhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good to try it locally to make sure it performs as expected. If we have a test that we can beef up to exercise that would be great.

@jimmyDunne jimmyDunne merged commit 051541a into master Jan 20, 2018
@jimmyDunne jimmyDunne deleted the ReporterSpatialVec branch January 20, 2018 03:40
@tkuchida tkuchida mentioned this pull request Jan 20, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aymanhab aymanhab aymanhab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jimmyDunne @chrisdembia @aymanhab