Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed duplicate scripts #1071

Merged
merged 2 commits into from
Nov 8, 2018
Merged

Conversation

jimmyDunne
Copy link
Member

Fixes issue opensim-org/opensim-models#102

Brief summary of changes

The Scripts that are used for the metabolics example have been moved to opensim-models and should be deleted here to avoid duplication

CHANGELOG.md (choose one)

  • no need to update because it is a file rearrangement

Copy link
Member

@aymanhab aymanhab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aymanhab aymanhab merged commit f9a53a9 into master Nov 8, 2018
@aymanhab
Copy link
Member

aymanhab commented Nov 8, 2018

Not sure if the branch will be reused vs. deleted and if other changes to models repo are coming, so I'll do neither, just let me know @jimmyDunne @chrisdembia

@chrisdembia
Copy link
Member

I'm pretty sure the branch is no longer needed. If it is, @jimmyDunne can push back his local copy.

@chrisdembia chrisdembia deleted the remove_scripts_that_are_in_opensim-models branch November 8, 2018 21:45
@jimmyDunne
Copy link
Member Author

Yep, the scripts now live in opensim-org/opensim-models. Thanks, Ayman.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants