-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{WIP} Major updates to Metabolic's Tutorial Package #104
base: master
Are you sure you want to change the base?
Conversation
This still requires changes to Confluence and a check that the targets are correct when the GUI builds. |
I was able to test the installed files layout, a picture of it is below. @chrisdembia, the code part of this is ready for review. I have run through all the files locally to test and have started making changes to a (copy) of the tutorial. If you could just have brief look through these files, build locally, and tell me if you see anything glaring? |
@jimmyDunne based on discussion in today's daily scrum, do you need to update the GUI scripts in this repo for 4.0? |
Scripts are removed from GUI in opensim-org/opensim-gui#1071 |
This PR removes CMC results from using different assistive devices. I'm alright with that but can you explain why you made that choice?
Makes sense. Are the ones in this repo up to date? |
@jimmyDunne the tutorial refers to I tried running a few of the GUI scripts and they didn't fully work. Maybe that's why the PR is WIP? |
@jimmyDunne let me know when I should review this again. By the way, there are merge conflicts now. |
This is proving to be too difficult to do before the release since I have to retrofit the entire example. Instead, I will do a temporary fix to make the example work 'as-is' and I can spend multiple days updating this tutorial after the release. @chrisdembia, thanks for looking through it. I will add this to a future sprint and I can update then. Thanks. |
Sounds like a good plan. |
Deals with issue #102
PR tries to;
(i) Removes Redundant files (copies in both Pipelines and Tutorials) and Script generated files (models that have had springs or metabolic probes added by scripts).
(ii) Renames files to better convey what they do
(iii) Rearranges the gait10dof18musc model distribution folder so that the External loads' error doesn't bring the tutorial to a halt (opensim-org/opensim-gui#1066).