Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{WIP} Major updates to Metabolic's Tutorial Package #104

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

jimmyDunne
Copy link
Member

Deals with issue #102

PR tries to;
(i) Removes Redundant files (copies in both Pipelines and Tutorials) and Script generated files (models that have had springs or metabolic probes added by scripts).
(ii) Renames files to better convey what they do
(iii) Rearranges the gait10dof18musc model distribution folder so that the External loads' error doesn't bring the tutorial to a halt (opensim-org/opensim-gui#1066).

@jimmyDunne jimmyDunne added this to the 20181105 milestone Nov 8, 2018
@jimmyDunne
Copy link
Member Author

This still requires changes to Confluence and a check that the targets are correct when the GUI builds.

@jimmyDunne jimmyDunne changed the title Major updates to Metabolic's Tutorial Package {WIP} Major updates to Metabolic's Tutorial Package Nov 8, 2018
@jimmyDunne
Copy link
Member Author

jimmyDunne commented Nov 8, 2018

I was able to test the installed files layout, a picture of it is below.

screen shot 2018-11-08 at 2 26 44 pm

@chrisdembia, the code part of this is ready for review. I have run through all the files locally to test and have started making changes to a (copy) of the tutorial. If you could just have brief look through these files, build locally, and tell me if you see anything glaring?

@chrisdembia
Copy link
Member

chrisdembia commented Nov 8, 2018

@jimmyDunne based on discussion in today's daily scrum, do you need to update the GUI scripts in this repo for 4.0?

@jimmyDunne
Copy link
Member Author

jimmyDunne commented Nov 8, 2018

Scripts are removed from GUI in opensim-org/opensim-gui#1071

@chrisdembia
Copy link
Member

This PR removes CMC results from using different assistive devices. I'm alright with that but can you explain why you made that choice?

I will delete the GUI Metabolics scripts from opensim-gui in a separate PR.

Makes sense. Are the ones in this repo up to date?

@chrisdembia
Copy link
Member

@jimmyDunne the tutorial refers to subject01_metabolics_path_actuator.osim, which I do not see in the models repo. What's the plan for this model? I think the Setup_CMC_ActuatorConstraints.xml file depends on it. I don't think there's a script for adding this path actuator.

I tried running a few of the GUI scripts and they didn't fully work. Maybe that's why the PR is WIP?

@chrisdembia
Copy link
Member

@jimmyDunne let me know when I should review this again. By the way, there are merge conflicts now.

@jimmyDunne
Copy link
Member Author

jimmyDunne commented Nov 11, 2018

This is proving to be too difficult to do before the release since I have to retrofit the entire example. Instead, I will do a temporary fix to make the example work 'as-is' and I can spend multiple days updating this tutorial after the release.

@chrisdembia, thanks for looking through it. I will add this to a future sprint and I can update then. Thanks.

@chrisdembia
Copy link
Member

Sounds like a good plan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants