-
Notifications
You must be signed in to change notification settings - Fork 218
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect master branch #195
Comments
Once we have immediate automated testing via #193, disabling direct pushes may be a good idea. I'm not convinced our developer pool is large enough to enforce code review by technical means rather than convention, though. For example, right now we only have one reviewer (me) and I'd like to be able to get my own code merged. 😉 |
LGTM (referring to Benjamin being able to merge his own code).
|
All OpenSlide repos now have branch protection enabled for the [1] Except for builds, to allow GitHub Actions to push automated commits. |
https://github.com/openslide/openslide/settings/branches/master
I recommend enabling all the options on this page. This will force integration tests to pass, branches to be up to date, and ensure code review happens (even for administrators). I don't think this will be too strict, but if so, we can weaken the settings.
This will help avoid push mistakes and improve code quality through automated and manual review.
The text was updated successfully, but these errors were encountered: