Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect master branch #195

Closed
agoode opened this issue Mar 8, 2017 · 3 comments
Closed

Protect master branch #195

agoode opened this issue Mar 8, 2017 · 3 comments

Comments

@agoode
Copy link
Member

agoode commented Mar 8, 2017

https://github.com/openslide/openslide/settings/branches/master

I recommend enabling all the options on this page. This will force integration tests to pass, branches to be up to date, and ensure code review happens (even for administrators). I don't think this will be too strict, but if so, we can weaken the settings.

This will help avoid push mistakes and improve code quality through automated and manual review.

@agoode agoode added this to the Robust code review process milestone Mar 8, 2017
@bgilbert bgilbert removed this from the Robust code review process milestone Mar 8, 2017
@bgilbert
Copy link
Member

bgilbert commented Mar 8, 2017

Once we have immediate automated testing via #193, disabling direct pushes may be a good idea. I'm not convinced our developer pool is large enough to enforce code review by technical means rather than convention, though. For example, right now we only have one reviewer (me) and I'd like to be able to get my own code merged. 😉

@jaharkes
Copy link
Member

jaharkes commented Mar 8, 2017 via email

@bgilbert
Copy link
Member

All OpenSlide repos now have branch protection enabled for the main branch. They all require PRs when merging [1], enforce CI checks where CI exists, and enforce those rules against administrators. For the reasons in #195 (comment), we currently don't require code review. We also don't require branches to be up to date because IMO that's an antipattern (unnecessary for slow projects, unworkable for fast ones). We can always revisit these settings later as needed.

[1] Except for builds, to allow GitHub Actions to push automated commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants