Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
Protect master branch #195
Comments
agoode
added the
enhancement
label
Mar 8, 2017
agoode
added this to the
Robust code review process
milestone
Mar 8, 2017
bgilbert
added the
development-process
label
Mar 8, 2017
bgilbert
removed this from the
Robust code review process
milestone
Mar 8, 2017
|
Once we have immediate automated testing via #193, disabling direct pushes may be a good idea. I'm not convinced our developer pool is large enough to enforce code review by technical means rather than convention, though. For example, right now we only have one reviewer (me) and I'd like to be able to get my own code merged. |
|
LGTM (referring to Benjamin being able to merge his own code).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
agoode commentedMar 8, 2017
https://github.com/openslide/openslide/settings/branches/master
I recommend enabling all the options on this page. This will force integration tests to pass, branches to be up to date, and ensure code review happens (even for administrators). I don't think this will be too strict, but if so, we can weaken the settings.
This will help avoid push mistakes and improve code quality through automated and manual review.