Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "Overview Dashboard" terraform code isn't static #44

Closed
lswith opened this issue Feb 2, 2022 · 2 comments
Closed

The "Overview Dashboard" terraform code isn't static #44

lswith opened this issue Feb 2, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@lswith
Copy link

lswith commented Feb 2, 2022

The "tf/dashboards/overview-.tf" file is constantly changing, each time I run "slogen . --apply --clean".

I believe this is because the map is unordered and the rows are being pulled out arbitrarily: https://github.com/SumoLogic-Labs/slogen/blob/main/libs/overview.go#L193

This means that my terraform code changes on each run, rather than being hermetic.

This is a low priority, but it would be nice to have these rows sorted.

@agaurav agaurav self-assigned this Feb 2, 2022
@agaurav agaurav added the enhancement New feature or request label Feb 2, 2022
@agaurav
Copy link
Contributor

agaurav commented Feb 2, 2022

Agreed, all the need loops in templates should be sorted by the resource name.
should be an easy change.

@agaurav
Copy link
Contributor

agaurav commented Mar 10, 2022

fixed in 9cc3f59

@agaurav agaurav closed this as completed Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants