Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#97 #99

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

#97 #99

wants to merge 1 commit into from

Conversation

aothms
Copy link
Member

@aothms aothms commented Dec 2, 2021

@JanoSlivka I think this fixes your issue but I don't want to merge it yet because it creates quite a bit of temporaries which hurt gc perf. Later if I find some time I'll optimize it and merge into master. Feel free to use as is.

@JanoSlivka
Copy link

Ok, thanks for fix this.

@JanoSlivka
Copy link

I tried it and I found a few problems:

  • 1 problem:
    I zoomed at an angle to measure 8.49 to the red point.
    Step1:
    zoom1
    Step:2
    zoom2
    Step:3
    zoom3
    And the measurement changed from three points to two

  • 2 problem:
    I zoomed to measure 2.72 to the red point.
    Step1:
    zoom4
    Step:2
    zoom5
    Step:3
    zoom6
    And the measured value is out

  • 3 problem:
    Maybe it's a problem, maybe not, but if I measure the distance, the infinite line is still displayed
    zoom7
    zoom8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants